Add macros to make codelets just declare their access and let the macro definition do what should be

Here is written down the set of generic macro I'm thinking of to make codelet declare their memory access (see !16 (closed))

For now they are very trivial, and produce exactly the same effect as with the current master. But then one can easily add the morse_desc_iscached() test, add statistics, etc. without having to change the codelets again.

I've put it in control/descriptor.h for simplicity, but we can of course push to runtime-specific code (which file?)

mentioned in merge request !16 (closed)

@thibault Great Idea !!!

Just need to do all the codelets :P. And Please, keep the copyright as 2014-2017. I'll try to make a script to merge the row w/ Inria alone and the one with the 4 instituts.

added 1 commit

• 53b883fc - Fix copyright

Compare with previous version

added 1 commit

• a2bde4b9 - use macros in all codelets

Compare with previous version

added 1 commit

• 9d20fcf2 - typo

Compare with previous version

added 1 commit

• e010fe7a - typo

Compare with previous version

here are the codelets :) I only tested the build, now we need to proofread them

I'm doing a first proofread pass

added 1 commit

• cac0a731 - typos

Compare with previous version

There it is, another proofread will probably not hurt :)

added 1 commit

• 815e8bab - Fix tile access

Compare with previous version

Good to proofread. I found two old mistakes :).

mentioned in merge request !30 (merged)

added 1 commit

• 7d740d57 - Fix memory access

Compare with previous version

Ok so a last thing after reading you merge request comment. I would put the macro in runtime/starpu/morse_starpu.h or runtime/starpu/runtime_codelets.h as it is for now specific to both StarPU and its codelets.

I assume that we could use similar things for PaRSEC, but as we might modify those macros to more StarPU specific functions, maybe we should move it to StarPU. I don't know. I have to make my mind :). If we say we keep it generic, then it's fine where it is.

Well, see the subsequent merge request for how I plan to integrate runtime-specific tests in there. I can backport that to this pull request if that makes things clearer

resolved all discussions

Fine, I didn't read the other one until the end when I saw if was the same changes :)

enabled an automatic merge when the pipeline for 7d740d57 succeeds

merged

mentioned in commit bed75474