Mentions légales du service

Skip to content
Snippets Groups Projects

Add macros to make codelets just declare their access and let the macro definition do what should be

Merged THIBAULT Samuel requested to merge thibault/chameleon:memaccess into master

Here is written down the set of generic macro I'm thinking of to make codelet declare their memory access (see !16 (closed))

For now they are very trivial, and produce exactly the same effect as with the current master. But then one can easily add the morse_desc_iscached() test, add statistics, etc. without having to change the codelets again.

I've put it in control/descriptor.h for simplicity, but we can of course push to runtime-specific code (which file?)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Good to proofread. I found two old mistakes :).

  • Mathieu Faverge mentioned in merge request !30 (merged)

    mentioned in merge request !30 (merged)

  • added 1 commit

    Compare with previous version

  • Ok so a last thing after reading you merge request comment. I would put the macro in runtime/starpu/morse_starpu.h or runtime/starpu/runtime_codelets.h as it is for now specific to both StarPU and its codelets.

    I assume that we could use similar things for PaRSEC, but as we might modify those macros to more StarPU specific functions, maybe we should move it to StarPU. I don't know. I have to make my mind :). If we say we keep it generic, then it's fine where it is.

  • Well, see the subsequent merge request for how I plan to integrate runtime-specific tests in there. I can backport that to this pull request if that makes things clearer

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading