Mentions légales du service

Skip to content
Snippets Groups Projects

SUMMA GEMM with A stationnary

Merged Mathieu Faverge requested to merge faverge/chameleon:feature/Astat-gemm into master

This MR integrates the work from @AntJego and @rperesso. Please, you should both review this request, such that we can move forward with the SYMM integration. @fpruvost and @agullo Don't hesitate to give feedbacks.

Edited by Mathieu Faverge

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @faverge @fpruvost @AntJego @rperesso ! Sounds all good to me!

  • Sounds good to me as well ; I like the way the pruning is done!

    Just to be clear, however, this version is not SUMMA without the use of newMadeleine. It should be reflected in the docs, maybe ?

    Moreover, the detection of collectives may be subjected to how the routine is used: for example in the test program, we cannot expect collectives to be scheduled as the DAG is submitted after the matrices are initialized. Nonetheless, in applications that use lengthy tasks to initialize B, I believe StarPU will have time to schedule things properly.

    Note that it is possible to hack StarPU to ensure the collectives are detected in any situations but I don't know if this is necessary to make this improvement.

    • Resolved by Mathieu Faverge

      Other question: do we need only the STARPU_MPI_REDUX, or both STARPU_REDUX and STARPU_MPI_REDUX ? I'm not sure f the behavior in a non mpi mode right now. (@thibault ?)

      I still need to find a way to detect the STARPU_MPI_REDUX correctly because what I'm doing right now is failing :(.

  • Mathieu Faverge marked this merge request as draft

    marked this merge request as draft

  • Mathieu Faverge added 8 commits

    added 8 commits

    • 24af46df - options: add an anforce option field to force the task submission
    • 17b328a0 - include: add enum to define the multiple GEMM variants
    • e5ed6932 - codelet_zgemm: add stationnary A variant of INSERT_TASK_zgemm
    • f5a0b96c - codelets: Add the sum reduction codelets codelet_zgersum
    • c577c558 - zgemm: Add stationnary A gemm variant
    • 45388be5 - gemm-Astat: store who has registered C in a generic way and enforce the task...
    • 411ae898 - zgemm: Enable switch from one variant of the gemm algorithm to another through environment variable
    • c890d5dc - doc: Add a paragraph about the gemm variants

    Compare with previous version

  • Mathieu Faverge mentioned in issue #110

    mentioned in issue #110

  • Mathieu Faverge added 11 commits

    added 11 commits

    • c890d5dc...2108cdee - 2 commits from branch solverstack:master
    • 0c7933c6 - cmake: detect STARPU_MPI_REDUX properly
    • abfc657d - options: add an anforce option field to force the task submission
    • 89bd0a46 - include: add enum to define the multiple GEMM variants
    • 48e80abe - codelet_zgemm: add stationnary A variant of INSERT_TASK_zgemm
    • 17c8633b - codelets: Add the sum reduction codelets codelet_zgersum
    • 1350eb2c - zgemm: Add stationnary A gemm variant
    • 9554c29b - gemm-Astat: store who has registered C in a generic way and enforce the task...
    • 8e8f55e0 - zgemm: Enable switch from one variant of the gemm algorithm to another through environment variable
    • a05db47f - doc: Add a paragraph about the gemm variants

    Compare with previous version

  • Mathieu Faverge marked this merge request as ready

    marked this merge request as ready

  • Mathieu Faverge added 5 commits

    added 5 commits

    • 45004755 - codelets: Add the sum reduction codelets codelet_zgersum
    • 3239b2ec - zgemm: Add stationnary A gemm variant
    • 27ff9c1c - gemm-Astat: store who has registered C in a generic way and enforce the task...
    • 4ab74d2f - zgemm: Enable switch from one variant of the gemm algorithm to another through environment variable
    • 8fe1f52a - doc: Add a paragraph about the gemm variants

    Compare with previous version

  • Mathieu Faverge added 5 commits

    added 5 commits

    • 64b7c1dc - codelets: Add the sum reduction codelets codelet_zgersum
    • f022250a - zgemm: Add stationnary A gemm variant
    • 5e60e4be - gemm-Astat: store who has registered C in a generic way and enforce the task...
    • 939b4e42 - zgemm: Enable switch from one variant of the gemm algorithm to another through environment variable
    • 09cce802 - doc: Add a paragraph about the gemm variants

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading