Mentions légales du service

Skip to content
Snippets Groups Projects

Starpu - OOC

Merged Mathieu Faverge requested to merge faverge/chameleon:starpu/ooc into master
All threads resolved!

Try to remove direct use of StarPU in OOC directory.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I'm actually surprised by this source code. What I had documented in 3e6305c6 was to define STARPU_DISK_SWAP, STARPU_DISK_SWAP_BACKEND, and STARPU_LIMIT_CPU_MEM variables, STARPU_DISK_SWAP notably allows to set the path where to store the ooc matrix.

    I understand that Chameleon would rather have non-STARPU-named variables, so perhaps the chameleon initialization function could rather set the STARPU-named variables from Chameleon-named variables? Or from Chameleon options.

  • I never touch this code, and I don't know who pushed it. My point here is to make things move forward and quickly get rid of StarPU references in examples/timings directory :). If you tell me this is incorrect, thus it may be worth removing completely this code, to redo it later more correctly.

  • Well, not completely (we still need the -ooc option to get proper behavior), but yes I guess we can drop most of it and let users use STARPU variables for now (but again the documentation from 3e6305c6 got lost and needs to be reintroduced)

  • Yes the --ooc option in the timing, but the example can be removed.

    Agreed for the documentation. I put it back right away. (I forgot about this, sorry)

  • Mathieu Faverge added 12 commits

    added 12 commits

    Compare with previous version

  • Mathieu Faverge added 30 commits

    added 30 commits

    Compare with previous version

  • Mathieu Faverge added 11 commits

    added 11 commits

    Compare with previous version

  • added 1 commit

    • ad978258 - Change the set of timing to test new functions and test OOC

    Compare with previous version

  • Mathieu Faverge resolved all discussions

    resolved all discussions

  • I removed the testing, and I added some tests for the OOC in timings. If you both don't see any mistake or anything missing, we can merge I guess.

  • @thibault Just in case you didn't receive the message.

  • That looks good to me.

  • Mathieu Faverge mentioned in commit 15ec5abc

    mentioned in commit 15ec5abc

  • Please register or sign in to reply
    Loading