Make cmake include starpu_simgrid_wrap.h only after tests

Because it #define main and thus makes link tests fail.

Thanks @thibault. I don't see any potential issue with this merge request as protected by CHAMELEON_SIMULATION. Green light for me.

@furmento btw, that's the reason for the option parsing error in simgrid mode

added 17 commits

• 168c6d1f...45c82f14 - 17 commits from branch solverstack:master

Compare with previous version

@thibault I forced a push on you master branch to rebase this MR and merge it.

added 1 commit

• 40514e2a - Make cmake include starpu_simgrid_wrap.h only after tests

Compare with previous version

enabled an automatic merge when the pipeline for 40514e2a succeeds

merged

mentioned in commit 9d11d21a

Could the chameleon submodule ID be updated? With the current tree, git clone --recursive git@gitlab.inria.fr:solverstack/chameleon.git still has

./cmake_modules/morse_cmake/modules/find/FindSTARPU.cmake:    list(APPEND REQUIRED_FLAGS "-include starpu_simgrid_wrap.h")

Yes but I would prefer to do it with a working CI. As soon as the CI is back, I'll do it.

It's not useless, it allows to make the main application get its main function redirected for simgrid. We just do not want to have it during cmake detection tests.

Indeed. It happens that chameleon.h includes simulate.h which includes starpu_simgrid_wrap.h, so that's why it actually works without the -include. It would be for external applications, in which the .c file that defines main() could perhaps not include chameleon.h, that it would be needed.

Err, it seems this has come back in both cmake places?!

$ git clone --recursive git@gitlab.inria.fr:solverstack/chameleon.git
$ cd chameleon
$ grep -r simgrid_wrap .
./include/chameleon/simulate.h:#include <starpu_simgrid_wrap.h>
./cmake_modules/morse_cmake/modules/find/FindSTARPU.cmake:    list(APPEND REQUIRED_FLAGS "-include starpu_simgrid_wrap.h")
./CMakeLists.txt:# Make cmake include starpu_simgrid_wrap.h (which #define main and thus makes #
./CMakeLists.txt:            list(APPEND CMAKE_REQUIRED_FLAGS "-include" "starpu_simgrid_wrap.h")

(showing up in CMakeLists.txt is expected, in ./cmake_modules/morse_cmake/modules/find/FindSTARPU.cmake it isn't.)

It seems like it's d73d6858 which reverted cmake_modules to dd40b792c7f27bd8644e7837b17dbc876f92eec7

I have submitted !110 (merged) which sets it back to f99bada1af8f986d91f651eb9748d0ac6367ef5e