Mentions légales du service

Skip to content
Snippets Groups Projects

Change scroll bar to resize like in GIMP

Merged ORDRONNEAU Camille requested to merge cordronn/vite:fix/scroll-bar into master

This fixes issue #33 (closed) and #51 (closed)

The main thing done was interpolating maximum scroll bar values, thus:

  • At a scaling of X, the slider will be 1/X of the entire slide bar
  • When going too far right or left, the slider resizes to a minimum of half it base size (so 1/2X when on a scaling of X)
Edited by ORDRONNEAU Camille

Merge request reports

Merge request pipeline #1009856 passed

Merge request pipeline passed for cbbc313d

Merged by Philippe SWARTVAGHERPhilippe SWARTVAGHER 11 months ago (Jul 19, 2024 3:53pm UTC)

Loading

Pipeline #1009878 passed

Pipeline passed for 11a83499 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Philippe SWARTVAGHER requested changes

    requested changes

  • added 1 commit

    Compare with previous version

  • Philippe SWARTVAGHER resolved all threads

    resolved all threads

  • added 3 commits

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • added 4 commits

    Compare with previous version

  • added 5 commits

    Compare with previous version

  • Mathieu Faverge changed milestone to %Vite 1.4

    changed milestone to %Vite 1.4

    • just moving a little bit the X slider shifts completely the trace to the left (seems to not happen anymore after zooming)
    • the button in the menu bar to realign the trace are not working anymore
    • have a look on how Gimp manages moving outside of images (we can discuss if this has to be done in the MR or a dedicated one)
    Edited by Philippe SWARTVAGHER
  • added 1 commit

    • 8bdd1f93 - Fix trace moving all the way when moving a little the scroll bar

    Compare with previous version

  • added 4 commits

    • 8bdd1f93...0ccffe44 - 2 commits from branch solverstack:master
    • 3fdeec83 - Fix scroll bar not resizing
    • 241e155b - Fix trace moving all the way when moving a little the scroll bar

    Compare with previous version

    • Trace view shifting completely when moving a little the scroll bars is fixed.
    • The realign buttons work for me, can you reproduce the bug ?
    • The way Gimp manage translating the image can be implemented, but this requires some changes in the core way trace position is managed. So I think this should be part of another MR.
    • Trace view shifting completely when moving a little the scroll bars is fixed.

    I confirm.

    • The realign buttons work for me, can you reproduce the bug ?

    No, I don't have the bug anymore.

    • The way Gimp manage translating the image can be implemented, but this requires some changes in the core way trace position is managed. So I think this should be part of another MR.

    Agree.

    I see another glitch (existing before this MR) : zoom a bit in the X axis, then the X slider allows to shift the trace to the left more than just completely to the left. I let you decide if you can fix it in this MR or not.

  • added 8 commits

    • 241e155b...a30abf26 - 6 commits from branch solverstack:master
    • c57a2b7b - Fix scroll bar not resizing
    • 6a5b174f - Fix trace moving all the way when moving a little the scroll bar

    Compare with previous version

  • ORDRONNEAU Camille marked this merge request as draft

    marked this merge request as draft

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading