Change scroll bar to resize like in GIMP
This fixes issue #33 (closed) and #51 (closed)
The main thing done was interpolating maximum scroll bar values, thus:
- At a scaling of X, the slider will be 1/X of the entire slide bar
- When going too far right or left, the slider resizes to a minimum of half it base size (so 1/2X when on a scaling of X)
Edited by ORDRONNEAU Camille
Merge request reports
Activity
- Resolved by Philippe SWARTVAGHER
- Resolved by Philippe SWARTVAGHER
The size of scroll bar changes, but it has some strange behavior:
- when I open a trace, the full trace is displayed (zoom 100%), yet the scroll rectangle takes only half the total bar width: I can still shift the trace to the left.
But maybe it is another bug.
added 3 commits
-
5f84dfc3...ee66f933 - 2 commits from branch
solverstack:master
- ca5267e3 - Fix scroll bar not resizing
-
5f84dfc3...ee66f933 - 2 commits from branch
added 3 commits
-
ca5267e3...71ee7bf0 - 2 commits from branch
solverstack:master
- 3529cb43 - Fix scroll bar not resizing
-
ca5267e3...71ee7bf0 - 2 commits from branch
added 3 commits
-
3529cb43...73442a9e - 2 commits from branch
solverstack:master
- 9485d990 - Fix scroll bar not resizing
-
3529cb43...73442a9e - 2 commits from branch
added 4 commits
-
9485d990...2554d286 - 3 commits from branch
solverstack:master
- 6e9ac555 - Fix scroll bar not resizing
-
9485d990...2554d286 - 3 commits from branch
added 5 commits
-
6e9ac555...6c17e51e - 4 commits from branch
solverstack:master
- b228d997 - Fix scroll bar not resizing
-
6e9ac555...6c17e51e - 4 commits from branch
changed milestone to %Vite 1.4
- just moving a little bit the X slider shifts completely the trace to the left (seems to not happen anymore after zooming)
- the button in the menu bar to realign the trace are not working anymore
- have a look on how Gimp manages moving outside of images (we can discuss if this has to be done in the MR or a dedicated one)
Edited by Philippe SWARTVAGHERadded 1 commit
- 8bdd1f93 - Fix trace moving all the way when moving a little the scroll bar
added 4 commits
-
8bdd1f93...0ccffe44 - 2 commits from branch
solverstack:master
- 3fdeec83 - Fix scroll bar not resizing
- 241e155b - Fix trace moving all the way when moving a little the scroll bar
-
8bdd1f93...0ccffe44 - 2 commits from branch
- Trace view shifting completely when moving a little the scroll bars is fixed.
- The realign buttons work for me, can you reproduce the bug ?
- The way Gimp manage translating the image can be implemented, but this requires some changes in the core way trace position is managed. So I think this should be part of another MR.
- Trace view shifting completely when moving a little the scroll bars is fixed.
I confirm.
- The realign buttons work for me, can you reproduce the bug ?
No, I don't have the bug anymore.
- The way Gimp manage translating the image can be implemented, but this requires some changes in the core way trace position is managed. So I think this should be part of another MR.
Agree.
I see another glitch (existing before this MR) : zoom a bit in the X axis, then the X slider allows to shift the trace to the left more than just completely to the left. I let you decide if you can fix it in this MR or not.
added 8 commits
-
241e155b...a30abf26 - 6 commits from branch
solverstack:master
- c57a2b7b - Fix scroll bar not resizing
- 6a5b174f - Fix trace moving all the way when moving a little the scroll bar
-
241e155b...a30abf26 - 6 commits from branch
assigned to @cordronn
unassigned @cordronn
Please register or sign in to reply