Mentions légales du service

Skip to content
Snippets Groups Projects

Draft: Adaptive batch size

Open Draft: Adaptive batch size
satanas-atos/chameleon:dyn_batch_size into master
2 unresolved threads
Open LISITO Alycia requested to merge satanas-atos/chameleon:dyn_batch_size into master
2 unresolved threads

Merge request reports

Merge request pipeline #1140990 failed

Stage: pre
    Stage: build
      Stage: test
        Stage: coverage
          Stage: analyze

            Merge request pipeline failed for 6d744002

            Loading
            Loading

            Activity

            Filter activity
            • Approvals
            • Assignees & reviewers
            • Comments (from bots)
            • Comments (from users)
            • Commits & branches
            • Edits
            • Labels
            • Lock status
            • Mentions
            • Merge request status
            • Tracking
            compute/pzgetrf.c
            41 int task_left = m / nb - k;
            42 int batch_max = chameleon_min( CHAMELEON_BATCH_SIZE, task_left );
            43 double flops = flops_zgetrf_blocked_offdiag( nb, nb, j, ws->ib );
            44 ws->batch_size = batch_max;
            45 if ( j != 0 ) {
            46 ws->batch_size = chameleon_min( chameleon_max( ws->flops_min / flops, 1 ), batch_max );
            47 }
            48
            49 if ( task_left % ws->batch_size != 0 ) {
            50 ws->batch_size = chameleon_min( chameleon_ceil( task_left, task_left / ws->batch_size ), batch_max );
            51 }
            52
            53 // batch_mathieu = chameleon_ceil( task_left,
            54 // chameleon_max( chameleon_ceil( task_left, batch_max ),
            55 // ( task_left * flops ) / ws->flops_th ) );
            56 }
            • Comment on lines +44 to +56
              Mathieu Faverge
              Mathieu Faverge @faverge ·
              Owner

              Si tu gardes les deux propositions, fait un #if defined(CHAMELEON_BATCH_MATHIEU) #else #endif :) histoire que la tienne soit par défaut

            • LISITO Alycia
              LISITO Alycia @alisito ·
              Author Developer

              Je l'ai juste laissé là pour qu'on ait la formule mais vu que ma formule donnait des résultats un peu mieux on n'a pas besoin de garder cette formule non ?

            • Mathieu Faverge
              Mathieu Faverge @faverge ·
              Owner

              Ben je l'aimais bien moi :D Elle est plus compréhensible non ? :) (et sinon je viens de tilter qu'on est passé en français :) )

            • Please register or sign in to reply
          • Mathieu Faverge
            Mathieu Faverge @faverge started a thread on the diff
            • compute/zgetrf.c
            124 126 ws->batch_size_blas3 = ( ws->batch_size_blas3 > CHAMELEON_BATCH_SIZE ) ? CHAMELEON_BATCH_SIZE : ws->batch_size_blas3;
            125 127 ws->batch_size_swap = chameleon_getenv_get_value_int( "CHAMELEON_GETRF_BATCH_SIZE_SWAP", batch_size );
            126 128 ws->batch_size_swap = ( ws->batch_size_swap > CHAMELEON_BATCH_SIZE ) ? CHAMELEON_BATCH_SIZE : ws->batch_size_swap;
            129 ws->flops_min = chameleon_max( chameleon_getenv_get_value_int( "CHAMELEON_GETRF_FLOPS_MIN_BATCH", 26e6 ), 1 );
            Please register or sign in to reply