Enable non uniform tile sizes

The goal of this MR is to enable non uniform tile sizes. This is a first step where all computations of dimensions which are the usual formula:

tempXY = X == desc->Yt - 1 ? desc->Y - X * desc->Yb : desc->Yb;

need to be replaced by a function that takes into account at least desc, X and Y, but that may not work in all cases, so this is an ongoing work. The choice has been made to a descriptor function get_blkdim to follow the get_blkXXX functions. A standard function that is working for regular tiles have been added by default.

changed milestone to %Chameleon 1.3.0

added API Feature labels

requested review from @x-hoogv

assigned to @faverge

added 15 commits

• 6848e392...d46110a3 - 14 commits from branch solverstack:master
• edbd9b6f - compute: replace dimension formula by correct function call

Compare with previous version

added 6 commits

• edbd9b6f...67fbb6d8 - 2 commits from branch solverstack:master
• 606c1058 - compute/{lascal/tradd}: Fix a potential bug due to a typo
• ded43410 - compute/pzunm{qr,lq}rh: Fix an incorrect dimension
• cbef919f - compute/plrnk: Fix workspace dimensions
• e73747d6 - compute: Qery-replace all tile dimension computation by a descripto function...

Compare with previous version

added 2 commits

• 2da99c85 - compute: Query-replace all tile dimension computation by a descripto function...
• e9b0bc5f - descriptor: Add the getblkdim function to prepare the switch in tile dimension computations

Compare with previous version

added 2 commits

• a2e41e6a - descriptor: Add the getblkdim function to prepare the switch in tile dimension computations
• d1e9302b - compute: Query-replace all tile dimension computation by a descripto function...

Compare with previous version

marked this merge request as ready

added 7 commits

• d1e9302b...57d4661d - 2 commits from branch solverstack:master
• 4cb7a219 - compute/{lascal/tradd}: Fix a potential bug due to a typo
• d7570fed - compute/pzunm{qr,lq}rh: Fix an incorrect dimension
• 9c213f86 - compute/plrnk: Fix workspace dimensions
• 5dc8c5b0 - descriptor: Add the getblkdim function to prepare the switch in tile dimension computations
• 8c8637bc - compute: Query-replace all tile dimension computation by a descripto function...

Compare with previous version

@faverge Les tempXY dont tu remplaces la formule correspondent au calcul des dimensions de la tuile courante, c'est ça ?

added 1 commit

• aaa1a9e1 - compute: Query-replace all tile dimension computation by a descripto function...

Compare with previous version

Should be good for review. @bnicolas Maybe you should have a look too as it might be useful for the tensors.

approved this merge request

unapproved this merge request

By the way, I tried to separate commit in:

• commits that fixes issues discovered while doing the changes
• one that add the functions and everything necessary to apply it
• One huge commit that query replace all found formulae that were respecting the right format, I hope that not too many variables were computing with a different format such that we don't have too many issues when really moving to variadic tile sizes.

changed the description

approved this merge request

Analysis Details

6 Issues

• 0 Bugs
• 0 Vulnerabilities
• 6 Code Smells

Coverage and Duplications

• No coverage information (28.30% Estimated after merge)
• No duplication information (17.50% Estimated after merge)

Project ID: solverstack_chameleon_AZJTCfl1sbMNg1jXgm3k

View in SonarQube

approved this merge request

added 2 commits

• 20780025 - descriptor: Add the getblkdim function to prepare the switch in tile dimension computations
• 42b2eff7 - compute: Query-replace all tile dimension computation by a descripto function...

Compare with previous version

resolved all threads

Is it possible to add another function in addition to get_blkdim( desc, m, DIM_m, desc->m ) that implicitly use desc->m internally ? e.g. get_blkdim( desc, m, DIM_m ). Because if I understand well this last parameter will not change very often ? This could ease reading.

approved this merge request

added 9 commits

• 42b2eff7...588e3359 - 4 commits from branch solverstack:master
• 785173ca - compute/{lascal/tradd}: Fix a potential bug due to a typo
• 53f7c61b - compute/pzunm{qr,lq}rh: Fix an incorrect dimension
• b6061fcb - compute/plrnk: Fix workspace dimensions
• 0e56a1ba - descriptor: Add the getblkdim function to prepare the switch in tile dimension computations
• 5b26256a - compute: Query-replace all tile dimension computation by a descripto function...

Compare with previous version

enabled an automatic merge when all merge checks for 5b26256a pass

mentioned in commit b3bcf76d

merged