Mentions légales du service

Skip to content
Snippets Groups Projects

Check that CHAMELEON_Init() was successful in testing

Merged Check that CHAMELEON_Init() was successful in testing
pswartva/chameleon:check_chameleon_init into master
All threads resolved!
Merged Philippe SWARTVAGHER requested to merge pswartva/chameleon:check_chameleon_init into master
All threads resolved!

Hello,

Everything is in the title of the MR / commit message.

You can test it with STARPU_NCPU=1 STARPU_MAIN_THREAD_BIND=1 mpirun ./chameleon_stesting -o potrf. Without my patch, StarPU fails silently in its initialization, but yells and aborts when the first task is submitted. The failure in StarPU initialization is "normal": STARPU_MAIN_THREAD_BIND=1 retrieves one core to the number of cores; and in this case, there is no remaining worker available to execute tasks.

Also I noticed function documentation is not consistent: https://gitlab.inria.fr/solverstack/chameleon/-/blob/master/include/chameleon/runtime.h#L117 says >0 on success to initialize the runtime, while https://gitlab.inria.fr/solverstack/chameleon/-/blob/master/control/control.c#L52 says @retval CHAMELEON_SUCCESS successful exit, it returns well CHAMELEON_SUCCESS in case of success, but CHAMELEON_SUCCESS is defined as 0, which is incoherent with the first comment (or the first comment is incorrect, I don't know :wink: ).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mathieu Faverge added 3 commits

    added 3 commits

    • af648c57 - runtime: Fix returned value by RUNTIME_Init
    • 3ab3f937 - runtime: Fix returned value by RUNTIME_Init
    • 35b81738 - Fix return value when calling RUNTIME_Init()

    Compare with previous version

  • Mathieu Faverge resolved all threads

    resolved all threads

  • Mathieu Faverge approved this merge request

    approved this merge request

  • Mathieu Faverge
    Mathieu Faverge @faverge ·
    Owner

    @pswartva I updated your PR. Please approve it, if it's ok for you, and I'll merge it.

  • Philippe SWARTVAGHER
    Philippe SWARTVAGHER @pswartva ·
    Author Developer

    LGTM.

  • Philippe SWARTVAGHER approved this merge request

    approved this merge request

  • Mathieu Faverge added 1 commit

    added 1 commit

    • b3996924 - ci: Enable detached build, and add the interuptible flag

    Compare with previous version

  • Mathieu Faverge added 1 commit

    added 1 commit

    • 7c827933 - ci: Enable detached build, and add the interuptible flag

    Compare with previous version

  • Mathieu Faverge added 2 commits

    added 2 commits

    • 445057a7 - runtime: Fix returned value by RUNTIME_Init and chack it's returned value when called
    • 55f8907f - ci: Enable detached build, and add the interuptible flag

    Compare with previous version

  • Mathieu Faverge added 1 commit

    added 1 commit

    • 76be91b0 - ci: Enable detached build, and add the interuptible flag

    Compare with previous version

  • Mathieu Faverge merged

    merged

  • Mathieu Faverge mentioned in commit aad22dea

    mentioned in commit aad22dea

    • Please register or sign in to reply