Feature/issue94

• The API of Lapack_to_Tile/Tile_to_Lapack family function is modified to integrate the uplo parameter (This is done to enable the following points)
• A new option mtxfmt is introduced to change the allocation of the matrix.
  • 0: The matrices are allocated as a single big allocation
  • 1: The matrices are allocated tile by tile (Only with StarPU)
  • 2: The matrices are out-of-core (Only with StarPU)
• Fix issue #96 (closed) by adding an example at the end of the usage function
• Fix an issue with the descriptor copy functions that was using the incorrect get_blkldd/get_blkaddr functions.

changed milestone to %Chameleon 1.1.0

added 5 commits

• 464dc2c5 - Use mtxfmt
• 623bf68d - Add mtxfmt parameter
• aa92e7e0 - mtxfmt is a parameter not a argument list
• d08b8c6e - Fix issue fix copy of descriptors
• efbb31e9 - Add uplo to lapack_to_tile/tile_to_lapack interfaces

Compare with previous version

added 4 commits

• b880bc8a - Add uplo to lapack_to_tile/tile_to_lapack interfaces
• bd2908f1 - Add an mtxfmt parameter to switch between the different allocation mode (Fix issue #94 (closed))
• 0109bc89 - Fix issue fix copy of descriptors
• 88def370 - Add an example at the end of usage (Fix issue #96 (closed))

Compare with previous version

unmarked as a Work In Progress

changed the description

added API Bug Feature labels

added 6 commits

• 88def370...f7fee936 - 2 commits from branch solverstack:master
• 9e0cee51 - Add uplo to lapack_to_tile/tile_to_lapack interfaces
• 700a5549 - Add an mtxfmt parameter to switch between the different allocation mode (Fix issue #94 (closed))
• f7500546 - Fix issue fix copy of descriptors
• 925f241f - Add an example at the end of usage (Fix issue #96 (closed))

Compare with previous version

added 4 commits

• c6b9ffcb - Add uplo to lapack_to_tile/tile_to_lapack interfaces
• bd827470 - Add an mtxfmt parameter to switch between the different allocation mode (Fix issue #94 (closed))
• abbb472a - Fix issue fix copy of descriptors
• 5d094c80 - Add an example at the end of usage (Fix issue #96 (closed))

Compare with previous version

@all Please havea quick check at this PR. If you have an issue with changing the lapack_to_tile/tile_to_lapack interface. Let me know.

@pswartva You can use this branch while waiting for it to be merged into the master.

I know. But do we really want to do it is another question :).

added 9 commits

• 5d094c80...65971522 - 5 commits from branch solverstack:master
• 3b738357 - Add uplo to lapack_to_tile/tile_to_lapack interfaces
• 5ad7983a - Add an mtxfmt parameter to switch between the different allocation mode (Fix issue #94 (closed))
• dc7064ed - Fix issue fix copy of descriptors
• a7baee49 - Add an example at the end of usage (Fix issue #96 (closed))

Compare with previous version

@faverge Thanks much for this improvement of the management of the data. Regarding @fpruvost remark, I agree and would vote for either waiting for merging until a major release is decided (or to agree that the next release will be a major one, at least in terms of numbering).

You could also give a new name to that function with the modified interface, so that you preserve the ancient function (mark it as obsolete ?), and the API. No need for a new major release.

I agree with @gsylvand but I had no idea to provide a new name, I was hoping someone would have. The other solution is to put in place something similar to what is done for open, but I don't know how it works.

We can also say that this function in not used (or should not be used) and change its interface without changing the major release. It is just a research library after all :)

#define CHAMELEON_Lapack_to_Tile( Af77, LDA, A ) CHAMELEON_Lap2Desc( ChamUpperLower, Af77, LDA, A )
#define CHAMELEON_Tile_to_Lapack( A, Af77, LDA ) CHAMELEON_Desc2Lap( ChamUpperLower, A, Af77, LDA )
int CHAMELEON_Lap2Desc( cham_uplo_t uplo, void *Af77, int LDA, CHAM_desc_t *A );
int CHAMELEON_Desc2Lap( cham_uplo_t uplo, CHAM_desc_t *A, void *Af77, int LDA );

Here is a suggestion.

Naming : add '_ext' or '_adv' or '_2' or '_new' to the existing name. Or change it completely, like CHAMELEON_zArray_to_ChamDesc. Regarding the fact of respecting the standard rules for versioning, it depends if you have users, and if you want to keep them ! As a user, I think it's better to respect it.

Or the deprecated version:

int CHAMELEON_Lapack_to_Tile( void *Af77, int LDA, CHAM_desc_t *A ) __attribute__((deprecated));
int CHAMELEON_Tile_to_Lapack( CHAM_desc_t *A, void *Af77, int LDA ) __attribute__((deprecated));

int
CHAMELEON_Lapack_to_Tile(  void *Af77, int LDA, CHAM_desc_t *A )
{
    return CHAMELEON_Lap2Desc( ChamUpperLower, Af77, LDA, A );
}

int
CHAMELEON_Tile_to_Lapack( CHAM_desc_t *A, void *Af77, int LDA )
{
    return CHAMELEON_Desc2Lap( ChamUpperLower, A, Af77, LDA );
}

To be sure people switch to the new one. This solution may be better.

@gsylvand I agree with you, I prefer to change as less as possible the interface, and as I explained @fpruvost, that's why I was putting on hold the release because I knew some changes would happened. I didn't thought about this one :)

added 6 commits

• a7baee49...305968ef - 2 commits from branch solverstack:master
• 955620e9 - Make lapack_to_tile/tile_to_lapack interfaces deprecated and add...
• 41f4196d - Add an mtxfmt parameter to switch between the different allocation mode (Fix issue #94 (closed))
• 598b4cd8 - Fix issue fix copy of descriptors
• aca9e4cb - Add an example at the end of usage (Fix issue #96 (closed))

Compare with previous version

added 4 commits

• 44ec1c4f - Make lapack_to_tile/tile_to_lapack interfaces deprecated and add...
• c6191d0f - Add an mtxfmt parameter to switch between the different allocation mode (Fix issue #94 (closed))
• b22d566f - Fix issue fix copy of descriptors
• 4fa31d7e - Add an example at the end of usage (Fix issue #96 (closed))

Compare with previous version

@gsylvand Done. If you see anything I miss let me know. Thanks

added 1 commit

• 5e1f4ffb - Add an example at the end of usage, and extend help for -o option (Fix issue #96 (closed))

Compare with previous version

mentioned in commit ad6c800f

merged