Mentions légales du service

Skip to content
Snippets Groups Projects
  1. Jul 30, 2021
  2. Jul 29, 2021
  3. Jul 28, 2021
  4. Jul 27, 2021
  5. Jul 26, 2021
    • E Madison Bray's avatar
      [bug] get rid of all default seeds in different configuration sources · 23eb4340
      E Madison Bray authored
      There are currently 3 "seed" options:
      
      1) A "seed" for simulations
      2) A "seed" for preprocessing (this mostly controls randomization of
      dataset splits)
      3) A "seed" for training
      
      All of these had default values in the default config files.  I think
      partly as an artifact of when I ported over some of Jean and Theophile's
      old config files into the code.
      
      In practice, users should expect stochasticity by default.  The schemas
      have a default value of "null" for all these seeds, which is equivalent
      to random seeding of the PNRG.  If users want to set a specific seed for
      reproducibility they should do so manually.
      
      (Possible future enhancement: Record the seed that was used so they can
      reproduce the same run even if the seed was not set explicitly first.)
      23eb4340
    • JAY Flora's avatar
      Merge branch 'jcury/documentation/training' into 'master' · de5f7c6e
      JAY Flora authored
      [doc] start work on training doc
      
      See merge request !95
      de5f7c6e
    • E Madison Bray's avatar
      [enhancement] in addition to `dnadna simulation run --overwrite` there · 254f0799
      E Madison Bray authored
      is now a recommended `--backup` flag which creates a backup of existing
      simulation data that could conflict with a previous simulation run
      
      Otherwise, passing --overwrite just deletes previous conflicting data.
      
      Here "conflicting" means the scenario params file is the same as the
      one in the simulation config file, or the scenario files have the same
      filename format as in the simulation config file.  If they are a
      different format (e.g. a simulation was run once, then the config file
      was changed to use a different filename format, and the simulation run
      again in the same directory) then there is no way to know for sure what
      files belonged to a previous simulation, under the current scheme.
      
      However, it shouldn't be a problem, in this (unusual) case, as the old
      simulation data won't conflict with the new simulation data, as it's in
      a different filename format.  This would have to be cleaned up manually
      by the user.  Or better still, a new simulation should be run in a new
      directory.
      
      The backup option moves all possibly conflicting files into a new
      `{data_root}/{dataset_name}-backup.{timestamp}` directory.
      254f0799
    • E Madison Bray's avatar
      [bug] by default do *not* overwrite an existing simulation params file · 3c9e5704
      E Madison Bray authored
      Instead, an error is raised indicating that the --overwrite flag should
      be used.  If giving --overwrite, then the existing file will be
      overwritten.
      
      When using the CLI, an existing file will never be loaded, though it
      remains an option when using the API (albeit a bit clunkily).
      3c9e5704
    • E Madison Bray's avatar
      [refactoring] remove the --scenario-params argument from `dnadna · bc601242
      E Madison Bray authored
      simulation run`
      
      This was a feature to allow specifying a different path to a scenario
      params file than the one in the config file.  In retrospect, this
      features does not make a lot of sense under the current design: In order
      to use it properly, the user would still have to modify their simulation
      config file to point to the correct scenario params file if they want to
      use it for training.
      
      This feature was not even covered by the tests.
      
      If the need for something like this arises in the future, we can
      reconsider how it should work.
      bc601242
    • E Madison Bray's avatar
      15e19ed2
    • E Madison Bray's avatar
      [enhancement] add option to overwrite an existing scenario params file · 359a68f7
      E Madison Bray authored
      and/or write a new one, rather than loading an existing one
      
      for the CLI this is now the default--when re-running a simulation it
      will overwrite the existing file
      
      as a further improvement, maybe we should only overwrite (or at least
      mention to the user) if the n_scenarios/n_replicates in the scenario
      params table is not consistent with what's in the config file
      359a68f7
Loading