[bug] Mismatch between simulation config and param file -> risk of mistake
(1) Maybe not really a bug, more a source of confusion and mistake.
While redoing the quickstart tuto I realized the following: if you run:
dnadna simulation init my_model one_event
dnadna simulation run my_model/my_model_simulation_config.yml
- Interrupt the run because you realize you should have changed the simulations settings so that your test run faster
- Modify my_model/my_model_simulation_config.yml to e.g. reduce the number of scenario and replicates
- Relaunch
dnadna simulation run my_model/my_model_simulation_config.yml
Then the changes do not take effect because dnadna simulation starts from my_model/one_event_params.csv
if it exists, which contains the parameter drawn at previous step (i.e with a different nb of replicates and scenarios)
It took my a bit of time to figure it out, and I suspect that could be a frequent issue for new users. There could be a question asking if one wants to overwrite one_event_params.csv
and/or a warning when the number of replicates and scenarios in the param file does not match the values in the simulation config, stating that one can manually remove the param file first? What do you think would be the best way to handle this ?
(2) Also, so that I don't forget, the order in the generated config file has changed as discussed, but it is now :
- preprocessing
- simulation
- training
instead of
- training
- preprocessing
- simulation
Maybe the order issue is not finalized yet, I think you mentioned that somewhere else.