Update pre-commit git hook and its documentation to clear executed cells from notebooks
This MR fixes #4 (closed)
Merge request reports
Activity
requested review from @steff
assigned to @vrouvrea
- Resolved by GILLES Sebastien
And a very minor nitpick I don't know anyway how to circumvent: the
git add
in the pre-commit assumes you want to commit any changes in the notebook file. If this file is in your staging area only for parts of the current modifications made locally you would commit the current state and not just the parts put in the staging area.
@vrouvrea The issue regarding the environment is not fixed: either we need to add vanilla Jupyter in our build, or we should use something else in the hook...
added 20 commits
-
f47a1b23...af0ad8ef - 19 commits from branch
formations/cpp:master
- f5cc57db - Merge remote-tracking branch 'upstream/master' into 4_pre_commit_git_hook
-
f47a1b23...af0ad8ef - 19 commits from branch
@sgilles Could you try again, please ? On my side since your modification in environment.yml,
jupyter nbconvert --clear-output --inplace *.ipynb
works fine.jupyter lab
is no more working, but we already discuss about it.added 36 commits
-
f5cc57db...78672720 - 35 commits from branch
formations/cpp:master
- dde63ab6 - merge master
-
f5cc57db...78672720 - 35 commits from branch
mentioned in commit 56c0191a