Update pre-commit git hook and its documentation to clear executed cells from notebooks

This MR fixes #4 (closed)

requested review from @steff

assigned to @vrouvrea

added 1 commit

• f47a1b23 - pre-commit should git add to work

Compare with previous version

I've tried it and it's not working for a trivial reason: I have installed the environment as suggested in the README and only JupyterLab is installed. So no jupyter nbconvert command...

And a very minor nitpick I don't know anyway how to circumvent: the git add in the pre-commit assumes you want to commit any changes in the notebook file. If this file is in your staging area only for parts of the current modifications made locally you would commit the current state and not just the parts put in the staging area.

@vrouvrea The issue regarding the environment is not fixed: either we need to add vanilla Jupyter in our build, or we should use something else in the hook...

added 20 commits

• f47a1b23...af0ad8ef - 19 commits from branch formations/cpp:master
• f5cc57db - Merge remote-tracking branch 'upstream/master' into 4_pre_commit_git_hook

Compare with previous version

@sgilles Could you try again, please ? On my side since your modification in environment.yml, jupyter nbconvert --clear-output --inplace *.ipynb works fine. jupyter lab is no more working, but we already discuss about it.

This is working on a Linux environment.

approved this merge request

unapproved this merge request

The hook doesn't work well with commands such as git commit --amend

added 36 commits

• f5cc57db...78672720 - 35 commits from branch formations/cpp:master
• dde63ab6 - merge master

Compare with previous version

I approve it - even if in some cases the git commit --amend doesn't work we can easily circumvent it.

approved this merge request

resolved all threads

merged

mentioned in commit 56c0191a