Rewrite partly the Dockerfile
So that:
- The image is derived from continuumio/miniconda3 rather than Ubuntu (maybe it is not the right call - no clue one way or another, but we probably have shave off a bit of space. The miniconda one is apparently base on Debian).
- The project is no longer cloned from gitlab, but is rather read from the host (the command line is therefore a bit longer and is documented in the README). The reason for doing so is that the image is lighter and fork may build their own image from their actual master branch rather than silently taking the one from the main project.
I have also removed several lines that seems to add nothing; maybe I was wrong on some of these calls.
The terminal where the run command is run is no longer silent; I don't know what triggered the difference here.
I assigned the issue to @vicente.mataix as he was the author of the first draft of the Dockerfile, but I would as usual gladly take input from you @vrouvrea and @steff.
Merge request reports
Activity
added Docker label
mentioned in merge request !14 (closed)
The project is no longer cloned from gitlab, but is rather read from the host (the command line is therefore a bit longer and is documented in the README). The reason for doing so is that the image is lighter and fork may build their own image from their actual master branch rather than silently taking the one from the main project.
That's clever, and avoids the need to create a new image each time the repo is changed
-
@sgilles This is ready now
-
I tested it and it works fine with jupyter lab (didn't check the bibliography bug). 1.2 Go later:
Status: Downloaded newer image for registry.gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp:latest [W 2021-05-06 08:04:11.450 LabApp] 'token' has moved from NotebookApp to ServerApp. This config will be passed to ServerApp. Be sure to update your config before our next release. /home/formation/.conda/envs/training_cpp_2021/lib/python3.9/site-packages/traitlets/traitlets.py:2196: FutureWarning: Supporting extra quotes around Unicode is deprecated in traitlets 5.0. Use '' instead of "''" – or use CUnicode. warn( [I 2021-05-06 08:04:11.458 ServerApp] jupyterlab | extension was successfully linked. [I 2021-05-06 08:04:11.471 ServerApp] Writing notebook server cookie secret to /home/formation/.local/share/jupyter/runtime/jupyter_cookie_secret [I 2021-05-06 08:04:11.680 ServerApp] nbclassic | extension was successfully linked. /home/formation/.conda/envs/training_cpp_2021/lib/python3.9/site-packages/traitlets/traitlets.py:2196: FutureWarning: Supporting extra quotes around Unicode is deprecated in traitlets 5.0. Use '' instead of "''" – or use CUnicode. warn( [W 2021-05-06 08:04:11.735 ServerApp] All authentication is disabled. Anyone who can connect to this server will be able to run code. [I 2021-05-06 08:04:11.746 LabApp] JupyterLab extension loaded from /home/formation/.conda/envs/training_cpp_2021/lib/python3.9/site-packages/jupyterlab [I 2021-05-06 08:04:11.747 LabApp] JupyterLab application directory is /home/formation/.conda/envs/training_cpp_2021/share/jupyter/lab [I 2021-05-06 08:04:11.754 ServerApp] jupyterlab | extension was successfully loaded. [I 2021-05-06 08:04:11.763 ServerApp] nbclassic | extension was successfully loaded. [I 2021-05-06 08:04:11.766 ServerApp] Serving notebooks from local directory: /home/formation/gettingstartedwithmoderncpp [I 2021-05-06 08:04:11.766 ServerApp] Jupyter Server 1.6.4 is running at: [I 2021-05-06 08:04:11.766 ServerApp] http://1edff1e6357f:8888/lab [I 2021-05-06 08:04:11.766 ServerApp] http://127.0.0.1:8888/lab -
@all If the new environment name is ok for everybody, I approve.
