Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • vidjil vidjil
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,715
    • Issues 1,715
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • vidjil
  • vidjilvidjil
  • Merge requests
  • !125

Merged
Created Nov 22, 2017 by Ryan Herbert@RyanHerbContributor

database.js fix upload forms

  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

Recent changes to the flow of the client, namely the removal of several calls to model.initClones, seem to have either caused, or brought to light another application flow issue. Where, when the server was returning an indication to the application that it should redirect the user to a new view, the call to the new view was called, but the execution of database.display_result(result) was continued, therefore attempting to identify further formats of potential server responses. Given that in such a context, there may be no samples initialised in the model, the application was crashing, therefore not cotinuing it's execution of the upload form controller initialisation.

This was causing the uploads to never occur. Closes #2849 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature-c/fix_flow_upload_error