Mentions légales du service

Skip to content
Snippets Groups Projects

Refacto DrawTrace

Merged ORDRONNEAU Camille requested to merge cordronn/vite:move/draw-trace into master
All threads resolved!

The code from DrawTrace was templated but this had no use because the type was always equal to GantDiagram. Thus DrawTrace methods were moved to the .cpp file for better code layout.

inlining has been removed because it is only useful for small functions which was not the case.

Some method were removed because they were small and only called one are two times without the need for an entire DrawTrace object.

There might still be rework to do :

  • The _filter attributes inside the trace is only used for zoom in DrawTrace but is always equal to 0. I don't know if this attributes had a real intended purpose so for now I did not touch it.
  • The GantDiagram object used everywhere in DrawTrace could be an attribute created with the constructor, but there will be some problem when DrawTrace is used for entity information because not GantDiagram object is created

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • dceb926c - Merge methods update_vertical_line into a unique function

    Compare with previous version

  • added 1 commit

    • 84a34dc4 - Merge methods update_vertical_line into a unique function

    Compare with previous version

  • added 3 commits

    • 0359f78c - 1 commit from branch solverstack:master
    • f7723879 - Refacto DrawTrace
    • 7805324e - Merge methods update_vertical_line into a unique function

    Compare with previous version

  • ORDRONNEAU Camille resolved all threads

    resolved all threads

  • Philippe SWARTVAGHER approved this merge request

    approved this merge request

  • mentioned in commit 704a87f9

  • changed milestone to %Vite 1.5

  • Please register or sign in to reply
    Loading