Work/bump standards

C++11 and Qt5.6 minimum

changed the description

added 5 commits

• 13f21f88 - 1 commit from branch master
• c7a2b949 - bump Qt minimal version to 5.6
• 92fdbe0d - require c++11
• b1adf0ad - add QT_USE_QSTRINGBUILDER definition
• f1776b62 - remove remnants of Qt4

Compare with previous version

added 4 commits

• 8c7610ce - bump Qt minimal version to 5.6
• 2e6b9b2e - require c++11
• 75513044 - add QT_USE_QSTRINGBUILDER definition
• bf2a94d5 - remove remnants of Qt4

Compare with previous version

added 5 commits

• 13f21f88 - 1 commit from branch master
• cb465a12 - bump Qt minimal version to 5.6
• 83849669 - require c++11
• 745d71a7 - add QT_USE_QSTRINGBUILDER definition
• 2ffd3503 - remove remnants of Qt4

Compare with previous version

added 4 commits

• 02aa5b3e - fix signal arguments need to be fully-qualified (QxtSpanSlider::SpanHandle...
• dc5e97ea - fix overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
• 4f496fca - fix unused QList<QTreeWidgetItem *> [-Wclazy-unused-non-trivial-variable]
• e12806c7 - fix Old Style Connect [-Wclazy-old-style-connect]

Compare with previous version

added 8 commits

• 4fc9fc5d - fix overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
• 4a7a8d53 - fix Old Style Connect [-Wclazy-old-style-connect]
• 21266264 - fix c++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
• 4f4b9abd - fix Pass small and trivially-copyable type by value (const class QPoint &)...
• 19f17034 - fix all QString(const char*) being called [-Wclazy-qstring-allocations]
• 2b41608b - add QT_NO_CAST_FROM_ASCII
• f7bb9368 - prevent crashes when opening the plugins window and no trace is loaded
• 63ed4c80 - remove render_stats* classes, no more used

Compare with previous version

assigned to @faverge

There are a lot of separated commits for each change, it may be easier to review commit by commit instead :)

added 1 commit

• dca37ca2 - add option to enable MPI via cmake

Compare with previous version

Why would we need MPI for ViTE ? I think I missed something :)

The code was already existing: https://gitlab.inria.fr/search?group_id=94&project_id=2748&scope=blobs&search=USE_MPI But there were no switch to activate it. Looking at the log, it was added 12 years ago.

Maybe it would be better to remove the code directly instead of handling it.

Ok, so it comes from the boost plugin. I never really tried it, and I don't know if someone is still using it. The problem is I don't know what was the original purpose. From what I remember it was made to read multiple files in parallel, and possibly read data on the fly, but I never tried.

I don't know either :D!

Let's keep it in this MR, but we should think about removing it to simplify the code if it's really not used.

@jjazeix Render stats is no more used ? Even by the statistics plugin ? If yes, I'm good with the PR and ok to merge.

approved this merge request

For information, I've compiled with: -DUSE_OPENGL=ON -DVITE_ENABLE_MPI=ON -DVITE_ENABLE_MT_PARSERS=ON -DVITE_ENABLE_OTF=ON -DVITE_ENABLE_OTF2=ON -DVITE_ENABLE_TAU=ON -DVITE_ENABLE_VBO=ON -DVITE_ENABLE_WARNING=ON and the four plugins.

added 1 commit

• c31c0083 - remove unused DrawCounter/Diagram/Stats files

Compare with previous version

resolved all threads

added 1 commit

• e537b89a - cmakelint all CMake files:

Compare with previous version

resolved all threads

approved this merge request

merged

mentioned in commit ee511e02