Mentions légales du service

Skip to content
Snippets Groups Projects

Fixing memory leak in the render system.

Merged Luca Bourroux requested to merge fix-leak into master
All threads resolved!

This merge request fixes some of the memory leak in the render system. To reproduce the leak you can load any trace and hit ctrl+r or the button Reload multiple times.

Beyond deleting what needed to be deleted I had to introduce a Shader pool to be able to clean everything up. Previously VBO used to own their shader but for some entities (like Arrow) two VBO shared the same shader. Just fixing the VBOs leak would then crash the program since a VBO will delete it's shader, and the next one would try to double delete it.

My fix removed the shader from the VBO's hands and we now have a shader pool that handles the shader life.

The memory leaks are especially present when a lot of arrows or events are present.

Edited by Mathieu Faverge

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mathieu Faverge resolved all threads

    resolved all threads

  • added 1 commit

    • 80c17e3b - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Mathieu Faverge approved this merge request

    approved this merge request

  • Mathieu Faverge marked this merge request as ready

    marked this merge request as ready

  • Mathieu Faverge mentioned in commit a4ab4681

    mentioned in commit a4ab4681

  • Please register or sign in to reply
    Loading