Fix display of variable lines with no variation or with invalid values (!21) · Merge requests · solverstack / vite · GitLab

Mentions légales du service

Snippets Groups Projects

A GitLab upgrade is scheduled for Monday, June 2, 2025. The service will be unavailable for a few minutes in the morning. We'll keep you posted on the progress of the upgrade on the Mattermost channel: https://mattermost.inria.fr/devel/channels/gitlab. We recommend that you do not work on the platform until an announcement indicates that maintenance is complete.

Merged Philippe SWARTVAGHER requested to merge pswartva/vite:fix-variable-line into master 5 years ago

Hello,

If a variable line contains only one value or if it contains many values, but they are all the same, there is a bug in displaying the line. There is also the same graphical bug if one of line values is nan or inf:

This PR fixes these two buggy cases:

Activity

Mathieu Faverge merged 5 years ago

merged
Mathieu Faverge mentioned in commit 9de075c0 5 years ago

mentioned in commit 9de075c0
Mathieu Faverge @faverge 5 years ago

Owner

@pswartva Sorry for the delay. I totally forgot about these PR. Both are merged now.
Philippe SWARTVAGHER @pswartva 5 years ago

Author Owner

Thank you ! I have several other ideas of things to fix/improve.
Mathieu Faverge @faverge 5 years ago

Owner

The issue is that it segfault if you enable VBO apparently.
Philippe SWARTVAGHER @pswartva 5 years ago

Author Owner

? This PR produces segfault with VBO ?

Please register or sign in to reply