Fix double click getting wrong container
Fix a bug where if the user double clicked on a container it would give the information of a container above it. This was due to container checking not taking into account for empty containers that are a bit smaller which created a shift. This shift was proportional to the number of empty containers that were above where the user clicked. The shift was around 0.2 render units, so 14% of a container height for each empty containers.
This bug was introduced in commit 7889c609
Merge request reports
Activity
changed milestone to %Vite 1.5
assigned to @cordronn
- Resolved by ORDRONNEAU Camille
It fixes the problem (kudos for finding it!).
However, I'm not convinced by the comment you added in the code, especially I don't find in it explications you put in the MR description, which I believe could also by somewhere in the code.
(Generally speaking, we should not put knowledge about the code itself in the VCS or the forge, but rather directly in the code: we will always have the code to work on, while there is no guarantee the commit and MR history will be there forever.)
mentioned in commit 4f23b6f6