Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E extras
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Si vous êtes un personnel Inria et que vous souhaitez participer aux tests de notre future plateforme Gitlab basée sur la version ultimate avec gitlab LFS activé merci de contacter Didier Chassignol.

  • The Openvibe Group
  • extras
  • Merge requests
  • !36

Use the parameters instead of hardwiring some values.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open PAPADOPOULO Theodore requested to merge SimpleBug into master Jul 16, 2019
  • Overview 0
  • Commits 1
  • Changes 1

The box ovpCBoxAlgorithmP300MagicCardVisualization (contrarily to the other boxes of the same family) has parameters to define the host and address to use for finding the acquisition server... but these parameters are not used and hard coded values are used (localhost and 15361). See issue *6.

Having these as parameters seems a good thing as otherwise this box will not work in cases where the acquisition-server and the designer are not on the same machine... Here I took the simple solution of keeping the parameters and using them.

Other possible solutions:

  • Remove the parameters from the box and simply forbid using this box in configurations where acquisition-server and designer are not run on the same machine... But then this needs to be documented.
  • A third solution would be to introduce some "global" parameter space where this can be set once for all the boxes of a scenario. But this raises the case of using multiple acquisition servers in a same scenario.... A solution would be to introduce an identifier for each acquisition server in a scenario and allow boxes to refer to this identifier. This is way beyond what I was willing to do here....
Edited Jul 16, 2019 by PAPADOPOULO Theodore
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: SimpleBug