Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E extras
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Openvibe Group
  • extras
  • Merge requests
  • !35

Use lua current version (not lua5.1) for all fedora builds.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open PAPADOPOULO Theodore requested to merge LinuxCompilation into master Jul 16, 2019
  • Overview 2
  • Commits 2
  • Changes 1

There are strange things hardwired in FindThirdPartyLua.cmake. Lua 5.1 is forced on windows and "unix if not fedora21". On recent fedora (tested with fedora 28/29), this (legacy?) library does not contain lua_setglobal (it seems it is contained in ubuntu lua5.1). FindThirdPartyLua.cmake has a "hardwired" correction for the specific version of fedora 21 (which is ~4 years old). Corrected by applying the fix to all fedora distributions (it currently selects lua5.3.so which indeed contains the lua_setglobal symbol).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: LinuxCompilation