Minor issues
Lisf of minor issues and suggestions:
-
displaying help in case of error
Description: in case of any error, the program displays the error then the full help page, which is very long and which usually completely hides the error message.
Suggestion a) reverse the order: display full help page, then error message after
Suggestion b) display error message, then a short comment like "for more information, type "programname --help" -
space between the different thresholds in a list:
Description: when user gives a list of thresholds, no space is allowed around the "," (for eg. "1000, 2000" is not allowed) and a strange error is displayed: "Error: stod"
Suggestion: at least display a clear error, otherwise the user will wonder what is wrong with the numerical value -
long command to write AP and DAP in the same output image
Description: if user wants AP and DAP in the same output image, the command looks like:
programname <apOptions> <dapFlag> <apOtions>
So the <apOtions> have to be repeated twice, otherwise the AP are calculated (for DAP) but not written.
Suggestion: add a flag to choose what will be written, like : writeOutput=AP or DAP or APDAP -
2 possible output folders for build
When using the make command to build Triskele, the output folder for build is ./build (as written in the makefile).
But when using the cmake command to build, to output folder is ../build (as mentioned in the instructions of the gitlab page)
It can be a little be confusing, especially if we have 2 copies of the executable files. In that case, when we do some modification on one of these copies, we are never sure which one is executed.
Suggestion: choose the same folder for both make and cmake.