Mentions légales du service

Skip to content
Snippets Groups Projects

Dnsconfig

Merged Dnsconfig
dnsconfig into master
1 unresolved thread
Merged JACQUOT Pierre requested to merge dnsconfig into master
1 unresolved thread

Related to bug 13637.

Avoid to generate bad DNS configuration, when the name field of a network device is the same as its uid.

Also, don't generate strange lines when the name field is empty.

Edited by JACQUOT Pierre

Merge request reports

Pipeline #404096 passed

Stage: validate
Stage: generate
Stage: deploy

Pipeline passed for 3763bd11 on dnsconfig

Approval is optional

Merged by JACQUOT PierreJACQUOT Pierre 3 years ago (Jan 20, 2022 5:08pm UTC)

Merge details

  • Changes merged into master with 82b2af92.
  • Deleted the source branch.

Pipeline #404105 passed

Stage: validate
Stage: generate
Stage: deploy
Stage: .post

Pipeline passed for 82b2af92 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
lib/refrepo/gen/puppet/bindg5k.rb
278 280 return records
279 281 end
280 282
283 def check_interface_name(node_uid, net_uid, net_hash)
284 if net_uid == net_hash['pname']
285 raise "Node #{node_uid} : #{net_uid} interface name is #{net_hash['pname']} ! Please put a predictable interface name to avoid bad DNS configuration."
  • JONGLEZ Baptiste
    JONGLEZ Baptiste @bjonglez
    Owner

    Ok sur le principe, il faut juste améliorer le message d'erreur.

  • JACQUOT Pierre added 2 commits

    added 2 commits

    • 135cfe96 - [bindg5k] Interface name check.
    • 34bc17f2 - [bindg5k] Don't generate lines when pname not set.

    Compare with previous version

  • JACQUOT Pierre added 8 commits

    added 8 commits

    Compare with previous version

  • JACQUOT Pierre
    JACQUOT Pierre @pijacquo
    Author Owner

    C'est corrigé, merci du retour. :thumbsup:

    Je merge dès que les tests sont passés.

  • JACQUOT Pierre merged

    merged

  • JACQUOT Pierre mentioned in commit 82b2af92

    mentioned in commit 82b2af92

    • Please register or sign in to reply