Merge branch 'rubocop-oar-props' into 'master'

Run rubocop over gen-oar-properties

See merge request !708

.gitlab-ci.yml

@@ -13,7 +13,7 @@ include:
       # Execute sonarqube
       - '/sonarqube.yml'
       # Execute rubocop
-      - '/rubocop-rails.yml'
+      - '/rubocop.yml'
       # Import g5k default stages
       - '/g5k-default-stages.yml'
 

.rubocop.yml

 ---
 Lint/UnusedBlockArgument:
   Severity: convention
+Style/HashSyntax:
+  # FIXME: change this when we enforce usage of ruby 3.
+  EnforcedShorthandSyntax: never

Gemfile

@@ -15,3 +15,5 @@ gem 'byebug'
 gem "ed25519"
 gem "bcrypt_pbkdf"
 gem "git"
+# To match https://gitlab.inria.fr/grid5000/grid5000-gitlab-templates/-/blob/master/rubocop.yml
+gem "rubocop", "1.34.1", :group => [:development]

Gemfile.lock

@@ -3,6 +3,7 @@ GEM
   specs:
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
     bcrypt_pbkdf (1.1.0)
     byebug (11.1.3)
     crack (0.4.5)
@@ -46,9 +47,16 @@ GEM
       net-ssh (>= 2.6.5)
       net-ssh-gateway (>= 1.2.0)
     netrc (0.11.0)
+    parallel (1.24.0)
+    parser (3.3.1.0)
+      ast (~> 2.4.1)
+      racc
     public_suffix (4.0.7)
+    racc (1.8.0)
+    rainbow (3.1.1)
     rake (13.0.6)
     rchardet (1.8.0)
+    regexp_parser (2.9.2)
     rest-client (2.1.0)
       http-accept (>= 1.7.0, < 2.0)
       http-cookie (>= 1.0.2, < 2.0)
@@ -68,11 +76,24 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
+    rubocop (1.34.1)
+      json (~> 2.3)
+      parallel (~> 1.10)
+      parser (>= 3.1.2.1)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.20.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
     ruby-cute (0.13)
       ipaddress (>= 0.8)
       json (>= 1.8)
       net-ssh-multi (>= 1.2)
       rest-client (>= 1.6)
+    ruby-progressbar (1.13.0)
     simplecov (0.21.2)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -82,6 +103,7 @@ GEM
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.8.2)
+    unicode-display_width (2.5.0)
     webmock (3.17.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -103,6 +125,7 @@ DEPENDENCIES
   net-ssh
   rake
   rspec
+  rubocop (= 1.34.1)
   ruby-cute
   simplecov
   webmock