IUAINFRA-48 code review

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/adapter/README.txt

-Put here classes from adapter layer :
-Data transformers, adapters, presenters or DAO. Abstraction of external libraries for
-application or business use.
-Web-services point, sockets, database connection and pool, GUI, file system, framework,
-external libraries.
\ No newline at end of file

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/application/README.txt

-Put here classes from application layer :
-Use cases. Business elements applied in an application context or scenario.
\ No newline at end of file

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/application/TokenGenerator.java

@@ -15,13 +15,15 @@ import net.ihe.gazelle.sb.jwtstandardblock.business.jwt.JSONWebSignature;
 import net.ihe.gazelle.sb.jwtstandardblock.business.jwt.JSONWebToken;
 import net.ihe.gazelle.sb.jwtstandardblock.business.jwt.JSONWebTokenClaimSet;
 
-import javax.inject.Inject;
 import java.nio.charset.StandardCharsets;
 import java.time.Duration;
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
 import java.util.UUID;
 
+/**
+ * Class to generate the token
+ */
 public class TokenGenerator {
 
     private static final String ALGORITHM = "HS256";
@@ -31,7 +33,6 @@ public class TokenGenerator {
 
     private AudienceSecretRetriever audienceSecretRetriever;
 
-    @Inject
     public void setAudienceSecretRetriever(AudienceSecretRetriever audienceSecretRetriever) {
         this.audienceSecretRetriever = audienceSecretRetriever;
     }

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/application/TokenRequestException.java

 package net.ihe.gazelle.app.accesstokenproviderapi.application;
 
+/**
+ * Class to manage token request exception
+ */
 public class TokenRequestException extends Exception {
 
     /**

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/application/exception/UnsupportedAlgorithmException.java

 package net.ihe.gazelle.app.accesstokenproviderapi.application.exception;
 
+/**
+ * Class to manage unsupported algorithm exception
+ */
 public class UnsupportedAlgorithmException extends Exception {
 
 
-
 }

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/application/exception/UnsupportedTokenTypeException.java

 package net.ihe.gazelle.app.accesstokenproviderapi.application.exception;
 
+/**
+ * Class to manage unsupported token exception
+ */
 public class UnsupportedTokenTypeException extends Exception {
 }

access-token-provider-api/src/main/java/net/ihe/gazelle/app/accesstokenproviderapi/business/README.txt

-Put here classes from business layer :
-Business model, rules and constraints. Always true. Independent from the application.
\ No newline at end of file

access-token-provider-api/src/test/java/net/ihe/gazelle/app/accesstokenproviderapi/adapter/README.txt

-Put here test classes for adapter layer.
\ No newline at end of file

access-token-provider-api/src/test/java/net/ihe/gazelle/app/accesstokenproviderapi/application/AudienceSecretRetrieverTestImpl.java

@@ -5,6 +5,9 @@ import net.ihe.gazelle.app.audienceretriever.application.AudienceSecretRetriever
 import java.util.HashMap;
 import java.util.Map;
 
+/**
+ * Class to test the retriever of the audience secret
+ */
 public class AudienceSecretRetrieverTestImpl implements AudienceSecretRetriever {
 
     private Map<String, String> registry = new HashMap<>();

access-token-provider-api/src/test/java/net/ihe/gazelle/app/accesstokenproviderapi/application/DummyAuthzServerSoapuiTest.java

 package net.ihe.gazelle.app.accesstokenproviderapi.application;
 
 import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.*;
 
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+/**
+ * Class to test the soapui authorization server
+ */
 class DummyAuthzServerSoapuiTest {
 
     private static final String SUBJECT = "aamrein";
@@ -13,11 +18,11 @@ class DummyAuthzServerSoapuiTest {
      */
     @Test
     public void getAccessTokenWithPathAudienceTest() {
-        DummyAuthzServerSoapui dummyAuthzServer = new DummyAuthzServerSoapui("src/test/resources/audience.properties");
+        DummyAuthzServerSoapui dummyAuthzServer = new DummyAuthzServerSoapui();
         dummyAuthzServer.setAudienceSecretRetriever((String audience) -> "myBeautifulKeyWhichIsAJWTSecretSoSecret");
 
 
-        assertNotNull(dummyAuthzServer.getAccessToken(SUBJECT, AUDIENCE, null, null));
+        assertNotNull(dummyAuthzServer.getAccessToken(SUBJECT, AUDIENCE, null, null), "check that the access token is not null");
     }
 
     /**
@@ -28,7 +33,7 @@ class DummyAuthzServerSoapuiTest {
         DummyAuthzServerSoapui dummyAuthzServer = new DummyAuthzServerSoapui();
         dummyAuthzServer.setAudienceSecretRetriever((String audience) -> "myBeautifulKeyWhichIsAJWTSecretSoSecret");
 
-        assertNotNull(dummyAuthzServer.getAccessToken(SUBJECT, AUDIENCE, null, null));
+        assertNotNull(dummyAuthzServer.getAccessToken(SUBJECT, AUDIENCE, null, null), "check that the access token is not null");
     }
 
     /**
@@ -37,6 +42,6 @@ class DummyAuthzServerSoapuiTest {
     @Test
     public void getAccessTokenWithBadPathAudienceTest() {
         DummyAuthzServerSoapui dummyAuthzServer = new DummyAuthzServerSoapui("test.properties");
-        assertNull(dummyAuthzServer.getAccessToken(SUBJECT, AUDIENCE, null, null));
+        assertNull(dummyAuthzServer.getAccessToken(SUBJECT, AUDIENCE, null, null), "check that the access token is null");
     }
 }

access-token-provider-api/src/test/java/net/ihe/gazelle/app/accesstokenproviderapi/application/README.txt

-Put here test classes for application layer.
\ No newline at end of file

access-token-provider-api/src/test/java/net/ihe/gazelle/app/accesstokenproviderapi/business/README.txt

-Put here test classes for business layer.
\ No newline at end of file

access-token-provider-api/src/test/resources/README.txt

-Put here your test resources.
\ No newline at end of file

audience-retriever/src/main/java/net/ihe/gazelle/app/audienceretriever/adapter/README.txt

-Put here classes from adapter layer :
-Data transformers, adapters, presenters or DAO. Abstraction of external libraries for
-application or business use.
-Web-services point, sockets, database connection and pool, GUI, file system, framework,
-external libraries.
\ No newline at end of file

audience-retriever/src/main/java/net/ihe/gazelle/app/audienceretriever/application/README.txt

-Put here classes from application layer :
-Use cases. Business elements applied in an application context or scenario.
\ No newline at end of file

audience-retriever/src/main/java/net/ihe/gazelle/app/audienceretriever/business/README.txt

-Put here classes from business layer :
-Business model, rules and constraints. Always true. Independent from the application.
\ No newline at end of file

audience-retriever/src/test/java/net/ihe/gazelle/app/audienceretriever/adapter/AudienceSecretRetrieverForSoapuiTest.java

@@ -5,6 +5,9 @@ import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertNull;
 
+/**
+ * Class to test the retrieve of the audience secret
+ */
 class AudienceSecretRetrieverForSoapuiTest {
 
     @Test

audience-retriever/src/test/java/net/ihe/gazelle/app/audienceretriever/adapter/README.txt

-Put here test classes for adapter layer.
\ No newline at end of file

audience-retriever/src/test/java/net/ihe/gazelle/app/audienceretriever/application/README.txt

-Put here test classes for application layer.
\ No newline at end of file

audience-retriever/src/test/java/net/ihe/gazelle/app/audienceretriever/business/README.txt

-Put here test classes for business layer.
\ No newline at end of file