Mentions légales du service

Skip to content
Snippets Groups Projects

Propose English corrections

Closed Propose English corrections
bnguyenv/gettingstartedwithmoderncpp:prop-corrections into master
1 unresolved thread
Closed NGUYEN-VAN-YEN Benjamin requested to merge bnguyenv/gettingstartedwithmoderncpp:prop-corrections into master
1 unresolved thread

Hello, here are some English changes that I believe are correct and/or improve the flow of the text. The commits are by notebook or notebook chapter, but I would recommend simply squashing them all together before merging.

Thank you very much for the training course !

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
2-ObjectProgramming/7-polymorphism.ipynb
17 17 "\n",
18 18 "[So far](./6-inheritance.ipynb), I have not yet shown how objects could be stored in the same container, which was a justification I gave when introducing inheritance.\n",
19 19 "\n",
20 "The first idea would be to cram all items in a container which type is the base class:\n",
20 "The first idea would be to cram all items in a container whose type is the base class:\n",
  • GILLES Sebastien approved this merge request

    approved this merge request

  • GILLES Sebastien
    GILLES Sebastien @sgilles
    Owner

    As suggested by @bnguyenv , I have rebased all the corrections in one commit; I have also added his name in the copyright file.

    The MR will not be merged directly as a result - but the content has been pushed inside master nonetheless.

    Thanks @bnguyenv !

  • GILLES Sebastien closed

    closed

    • Please register or sign in to reply