Closed
Milestone
SP15-Item04 - Improve Code Quality - Refactoring
Milestone ID: 2832
Improve coding readability by refactoring classes on node side and classes related to communication
-
classes + variables classes review, in order to decide which variable belongs to what class and design clean APIs (https://notes.inria.fr/IB0V3GGLSWaiFvwfvO-3iw) -
agree on coding style, rules and conventions to provide a similar code (code style independant of the developer) -> decide if/then/how to use dedicated tools to insure the respect of the coding style -
coherent naming of the files (eg: _fedbiosklearn.py, _torchnn.py) and directory tree organisation -
create issues for each basic class to be redesigned (candidates: Message, Messaging, Round, Job,..) - [.] simplify the user input check on Training Arguments (TrainingArgument class ? ValidityCheck helpers ?,..) [JLS]
-
implement sklearn classes as a class hierarchy (one sklearn training plan class per file) -> does it mean we will use SGDRegressorTrainingPlan
in the Training Plan? (Rihame) -
Decide whether should we add more tests in this user story (if there is time for that) (JLS: don't know what this means)
Linked to #249 #250 (closed)