Mentions légales du service

Skip to content

fixes regarding sklearn updates

BOUILLARD Yannick requested to merge hotfix/sklearn_model into master

MR description

Provides fixes to updates issues in sklearn models, mainly:

  1. wrong "gradient" sign for native sklearn updates (we are wrongly doing SGD w(t+1) = w(t) + lr * gradients but should be w(t+1) = w(t) - lr * gradients

  2. w_init in the train method has shared references with model layers, so calling model.partial_fit will wrongly update w_init

Developer Certificate Of Origin (DCO)

By opening this merge request, you agree the Developer Certificate of Origin (DCO)

This DCO essentially means that:

  • you offer the changes under the same license agreement as the project, and
  • you have the right to do that,
  • you did not steal somebody else’s work.


Project code files should begin with these comment lines to help trace their origin:

# This file is originally part of Fed-BioMed
# SPDX-License-Identifier: Apache-2.0

Code files can be reused from another project with a compatible non-contaminating license. They shall retain the original license and copyright mentions. The file and credit/ directory shall be completed and updated accordingly.

Guidelines for MR review


Specific to some cases:

  • update all conda envs consistently (development and vpn, Linux and MacOS)
  • if modified researcher (eg new attributes in classes) check if breakpoint needs update (breakpoint/load_breakpoint in Experiment(), save_state/load_state in aggregators, strategies, secagg, etc.)
Edited by BOUILLARD Yannick

Merge request reports