Mentions légales du service

Skip to content

Feature/433 ordering in fedavg

CREMONESI Francesco requested to merge feature/433-ordering-in-fedavg into develop

Fixes #433 (closed).

Implementation logic: try to minimize changes, and delegate to #417 (closed) the improvement of the representation of model parameters and weights. One exception to this is the addition of the compute_weights_for_averaging function in strategy, which will become very useful to simplify the implememtation of custom strategies (e.g. for MedicalFolderDataset). I also provide a test that reproduces the bug.

MR description


Developer Certificate Of Origin (DCO)

By opening this merge request, you agree the Developer Certificate of Origin (DCO)

This DCO essentially means that:

  • you offer the changes under the same license agreement as the project, and
  • you have the right to do that,
  • you did not steal somebody else’s work.


Project code files should begin with these comment lines to help trace their origin:

# This file is originally part of Fed-BioMed
# SPDX-License-Identifier: Apache-2.0

Code files can be reused from another project with a compatible non-contaminating license. They shall retain the original license and copyright mentions. The file and credit/ directory shall be completed and updated accordingly.

Guidelines for MR review


Specific to some cases:

  • update all conda envs consistently (development and vpn, Linux and MacOS)
  • if modified researcher (eg new attributes in classes) check if breakpoint needs update (breakpoint/load_breakpoint in Experiment(), save_state/load_state in aggregators, strategies, secagg, etc.)

Merge request reports