`declearn` integration into `Fed-BioMed`: decide how to import code
Regarding declearn
Optimizer
integration, we need to decide how to integrate declearn
work into FedBioMed:
- copying
declearn
code into FedBioMed - importing
declearn
as a third party package
declearn
package into fedbiomed
1. Pros and cons of copying Pros:
-
declearn
api may diverge in the future, interoperability with FedBioMed may not be always granted - we can fine tune
Optimizers
to adapt to fedbiomed
Cons:
- we also have to provide unit tests for those
Optimizers
(unit test code can be copied fromdeclearn
)
declearn
package
2. Pros and cons of importing Pros:
-
declearn
team will deal with FedBioMed interoperability -
declearn
team will take care of testing/bug patching
Cons:
- regarding
Optimizer
class, there might be some connection with otherdeclearn
modules (this will be fixed bydeclearn
team in the future) -
declearn
will come additional packages and code, that will make fedbiomed even heavier (this will be fixed bydeclearn
team in the future)
Edited by BOUILLARD Yannick