Please remove `--root $(CURDIR)` from make

Can you please apply the following patch:

https://github.com/coq/platform/blob/main/opam/opam-coq-archive/released/packages/coq-itauto/coq-itauto.8.18.0/files/0001-Remove-root-on-dune-calls-does-not-work-on-Windows-M.patch

I have itauto in Coq Platform with this patch on all platforms since a while and haven't heard of any issues. Also I would think that the current directory is anyway the default root of dune.

On Windows it does not compile without this patch because this is a cygwin MinGW cross build where make is cygwin and dune is MinGW so dune does not understand the cygwin absolute path provided by make.

mentioned in issue #36 (closed)

I did it in the past and had to revert. IIRC, this was breaking the coq CI.

I don't know how to proceed...

I do not have a windows box. Does commit 333303e5 fixes the issue?

I expect that this will work. The patch I am currently using is:

https://github.com/coq/platform/blob/main/opam/opam-coq-archive/released/packages/coq-itauto/coq-itauto.8.20.0/files/0001-Remove-root-on-dune-calls-does-not-work-on-Windows-M.patch

The only difference to your commit is the addition of (lang dune 2.9), which should not make a difference.

I am closing for now. Hopefully forever.

closed