Mentions légales du service

Skip to content
Snippets Groups Projects
Commit 6d3d5f65 authored by hhakim's avatar hhakim
Browse files

Modify matfaust.factparams.ParamsFact and sub-classes to decrease the number...

Modify matfaust.factparams.ParamsFact and sub-classes to decrease the number of mandatory arguments.

- The minimal set of arguments is the constraints + stopping criterion/criteria both for PALM4MSA and Hierarchical algos.
- The other arguments are optional thus they are set to their default values if not specified.
- The definition of default arguments is made in a keyword-value pair fashion; 'keyword1', value1, 'keyword2', value2. It resembles the way python authorizes keyword arguments after positional arguments. Likewise first arguments (constraints and StoppingCriterion-s) are mandatory so they are positional.
- The num_facts argument (number of factors of the factorization resulting product) is now deduced from the number of constraints. It avoids inconsistent setting of desired number of factors and number of constraints. But future simplified parametrization still will be able to define a targeted number of factors.
- Refactoring has been made for consistency and reusability between ParamsPalm4MSA, ParamsHierarchicalFact and their parent class ParamsFact.
parent 688c6b34
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment