Update/Fix TransformHelperGen::optimize_memory.

- time argument is false by default,
- copy of transpose/conjugate state.

src/faust_linear_operator/faust_TransformHelperGen.h

@@ -91,7 +91,7 @@ namespace Faust
 			virtual TransformHelper<FPP, DEV>* slice(faust_unsigned_int start_row_id, faust_unsigned_int end_row_id,
 					faust_unsigned_int start_col_id, faust_unsigned_int end_col_id);
 			TransformHelper<FPP, DEV>* fancy_index(faust_unsigned_int* row_ids, faust_unsigned_int num_rows, faust_unsigned_int* col_ids, faust_unsigned_int num_cols);
-			virtual TransformHelper<FPP,DEV>* optimize_storage(const bool time=true);
+			virtual TransformHelper<FPP,DEV>* optimize_storage(const bool time=false);
 			virtual TransformHelper<FPP,DEV>* clone();
 			virtual void convertToSparse()=0;
 			virtual void convertToDense()=0;

src/faust_linear_operator/faust_TransformHelperGen.hpp

@@ -399,13 +399,13 @@ namespace Faust
 		}
 
 	template<typename FPP, FDevice DEV>
-		TransformHelper<FPP,DEV>* TransformHelperGen<FPP,DEV>::optimize_storage(const bool time/*=true*/)
+		TransformHelper<FPP,DEV>* TransformHelperGen<FPP,DEV>::optimize_storage(const bool time/*=false*/)
 		{
 //			throw std::runtime_error("optimize_storage is yet to implement in Faust C++ core for GPU.");
 //			return nullptr;
 			Faust::MatDense<FPP,DEV> *dfac = nullptr;
 			Faust::MatSparse<FPP,DEV> *sfac = nullptr;
-			faust_unsigned_int sparse_weight;
+			faust_unsigned_int sparse_weight, dense_weight;
 			std::vector<Faust::MatGeneric<FPP,DEV>*> opt_factors;
 
 			for(auto fac : *(this->transform))
@@ -429,7 +429,8 @@ namespace Faust
 				else
 				{ // storage size is the main criterion
 					sparse_weight = fac->getNonZeros()*(sizeof(FPP)+sizeof(int))+(fac->getNbRow()+1)*sizeof(int);
-					if(sparse_weight < fac->getNBytes())
+					dense_weight = fac->getNbCol()*fac->getNbRow()*sizeof(FPP);
+					if(sparse_weight < dense_weight)
 					{
 						// choose CSR format
 						if(dfac)
@@ -448,8 +449,11 @@ namespace Faust
 				}
 			}
 			TransformHelper<FPP,DEV> *pth = new TransformHelper<FPP,DEV>(opt_factors, FPP(1), false, false, true);
+			//TODO: should use copy_transconj_state copy_slice_state
+			pth->is_transposed = this->is_transposed;
+			pth->is_conjugate = this->is_conjugate;
+//			this->mul_order_opt_mode = th.mul_order_opt_mode; // do not copy the mul method because it might be inefficient for the transpose case
 			return pth;
-
 		}
 
 	template<typename FPP, FDevice DEV>