branch double_matrix is going stale
(close this when double_matrix
passes CI cleanly)
Job #3081744 failed for 5dc306a9:
@x-cbouil @zimmerma The failure above, for example, was addressed by 377a7926; and there are many fixes in master that haven't found their way to double_matrix branch yet. I won't rebase / merge this myself, but please consider the different options.
Also, it would be very nice to see test cases for the functionality that this branch intends to provide.
For reference, whenever the CI jobs fail, it can be either:
- not your fault, but the fault of some bug in cado-nfs that shows up here and there. We're spending a good deal of time chasing these, so if such a thing happens it ought to be reported and/or investigated.
- not your fault, but a symptom of a bug that has already been fixed in cado-nfs, as in the failure there, which is exactly #30052 (closed). Finding out if this is the case is super easy, and then you really want to do something (rebase your branch, merge the master branch, or cherry-pick the fix. For WIP that no other branch relies on, rebasing is ok).
- not your fault, but something that is triggered by an external change (lately: debian9 repos being put offline as here, debian-testing adopting a new policy as here, gcc or clang version being bumped to the next major release as here, freebsd having a new release, etc). In this case, some action is required, a priori on the master branch, and I'd be very much happy to see people contribute on such things.
- not your fault, and actually nobody's fault but the CI system that just went bonkers, as here. When it's obvious that it's a transient failure, please try again with gitlab's "retry" button.
- 100% your fault as here ; then plean clean up after yourself. Force-pushing to overwrite a typo is sometimes a legitimate action in this case, since it's a WIP branch.
Anyway. The goal is that your branch passes CI, and when you decide that it's ready and it's sufficiently tested by the test suite, please merge it to master. If you're late in doing so (and so am I on my own branches), that leaves some pending work down the line.