Kills are broken with recent SimGrid versions
Batsim compiles and work with recent SimGrid as long as jobs are not killed.
I investigated the introduction of the bug thanks to git bisect.
bisect_log
Overview:
- Kills work in SimGrid 2017-06-13 1d26c9c43.
- Kills do not work in SimGrid 2017-06-22 39d5ec802.
Batsim kills work in these commits:
git bisect log | sed -n 's/git bisect good \(.*\)/git l | grep \1/p' | bash
* b13d1727c 2016-12-19 12:21:13 Martin Quinson Prepare the next release (refs/bisect/good-b13d1727c7bcdf873ada7fa4edb27eb53a219309)
* 53860f96b 2017-06-08 23:42:51 Frederic Suter oops, another module was dropped (refs/bisect/good-53860f96b2c6dd3174461e623f80c2f2086fd7f9)
* f1e5efb3d 2017-06-10 21:33:58 Martin Quinson NS3 probably don't like bandwidths in Bytes, so use bits (refs/bisect/good-f1e5efb3df61d23b5d75cdebd02a5f7b8a2d9477)
* fd9dfb431 2017-06-13 17:50:54 Frederic Suter Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid (refs/bisect/good-fd9dfb43196aed35d56c8f1f69de1493f2795c2d)
* 1d26c9c43 2017-06-13 18:24:35 degomme Update changelog for SMPI before release, this time. (refs/bisect/good-1d26c9c436dd9a0dc6b3a27bf0210edaef449170)
| * c4081e3a6 2017-06-14 08:57:05 Frederic Suter please both sonar and codacy (refs/bisect/good-c4081e3a628c6ab697d7958f3f22bdf788c0c13c)
| * 9f8cdec06 2017-06-14 09:33:18 Frederic Suter MC doesn'y like some of the explicit (refs/bisect/good-9f8cdec065147604e60ea03805456f604884d983)
Commits that compile, allow Batsim to compile and crash on kill
git bisect log | sed -n 's/\# bad...\(......\).*].*/git l | grep \1/p' | bash
* 03c1a9b98 2017-11-21 02:40:18 Martin Quinson Merge pull request #238 from barais/master (HEAD -> master, origin/master, origin/HEAD)
* | f6cb6d652 2017-08-28 20:39:15 Martin Quinson rename the instr::Container class to its proper name
* | 50ac3e136 2017-07-13 12:41:00 Martin Quinson codacy
* | 8f606525a 2017-07-12 10:05:14 Frederic Suter dict to map in vms
* | 39d5ec802 2017-06-22 20:37:30 Martin Quinson FIX THE LAST BORKEN TEST \o/
* | | | e4e8cad1f 2017-06-17 02:09:02 Martin Quinson fix gcc builds: missing prototype
* | | | eb642d393 2017-06-17 02:04:15 Martin Quinson cosmetics
| * | | | fe8edd20a 2017-05-29 11:14:25 Christian Heinrich Fixed spelling: zoneZoute -> zoneRoute
* | | | | 94eedaffd 2017-06-15 07:42:42 Martin Quinson fix the linkage declaration of a function (refs/bisect/bad)
Potential commits that caused the bug (do not compile :()
git bisect log | sed -n 's/\# possible first bad commit...\(......\).*].*/git l | grep \1/p' | bash
* | | | | 94eedaffd 2017-06-15 07:42:42 Martin Quinson fix the linkage declaration of a function (refs/bisect/bad)
* | | | | 3ba5d4a96 2017-06-15 03:58:51 Martin Quinson fix clang build (refs/bisect/skip-3ba5d4a966c2ac976b2b1656c52145f70189d108)
* | | | | 295d4bb2d 2017-06-15 03:36:57 Martin Quinson Don't use the C linkage when we use C++ datatypes (refs/bisect/skip-295d4bb2d007a034d9fbb67e6d15255f68ab75a6)
* | | | | 166ad1113 2017-06-15 03:14:16 Martin Quinson Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid (refs/bisect/skip-166ad11130482e81d2c3e860ab6c61e972a4cdf6)
* | | | | e3dc648bd 2017-06-15 03:13:35 Martin Quinson correctly use clumsy xbt_dynar interface (refs/bisect/skip-e3dc648bd52d77fd3b8f941c01de483c27ab960c)
* | | | | 965b2a6b2 2017-06-15 02:42:54 Martin Quinson we manipulate CommPtr and not Comm* nowadays (refs/bisect/skip-965b2a6b28501ae4e5f17ac438fb44685a0bb5d1)
* | | | | de0cd0ad6 2017-06-15 02:41:07 Martin Quinson Now this test may pass (refs/bisect/skip-de0cd0ad69890d63441635383794357e67144dd6)
* | | | | f6c0000d5 2017-06-15 02:31:21 Martin Quinson these static casts are useless (refs/bisect/skip-f6c0000d54b4220bfac8e0ff45f392d48b035e7c)
* | | | | b9a988d21 2017-06-14 23:46:30 Martin Quinson Merge branch 'ActivityPtr' of github.com:simgrid/simgrid into ActivityPtr (refs/bisect/skip-b9a988d21c6d27486d4acf043e43360688c1e749)
* | | | | | 8d8733c01 2017-06-14 23:31:21 Martin Quinson simplify this test for the ongoing debugging (refs/bisect/skip-8d8733c018b721a25cbab2edb8e7ba16fc98135a)
| * | | | | 173cb693c 2017-06-14 23:07:27 Gabriel Corona Fox broken CMakeLists.txt (refs/bisect/skip-173cb693c295a6bdcd83dee769435ea841e069ae)
* | | | | 8169282cc 2017-06-14 22:44:14 Martin Quinson simple test on waitany (refs/bisect/skip-8169282cca06266967c585e8619feed5a3905117)
* | | | | 6f0fdb5fe 2017-06-14 22:08:42 Martin Quinson bummer (refs/bisect/skip-6f0fdb5fef561abdb500ae463fa34614c07f44cc)
* | | | | 93797e97a 2017-06-14 21:35:03 Martin Quinson try to get the refcounting right on waitany simcalls (refs/bisect/skip-93797e97a5cd7517c65e1c22c208816a784f4c61)
* | | | | b7dfd2d06 2017-06-14 09:30:53 Martin Quinson fix the actor name; improve doc (refs/bisect/skip-b7dfd2d0666718ffbe2c5cec0dda8df486a7635c)
* | | | | 13cfb5c47 2017-06-08 07:08:24 Martin Quinson eradicate all remaining manual refcounting on ActivityImpl (refs/bisect/skip-13cfb5c4733854671750256e92a6aca384d25626)
* | | | | 8e4039652 2017-06-08 06:56:24 Martin Quinson refcount should be automatic now, and initialized to 0 (refs/bisect/skip-8e4039652526033642b167e65ad9c1e34fdd6c43)
* | | | | e94d63807 2017-06-08 02:22:52 Martin Quinson AH! there was a remaining manual refcount stain (refs/bisect/skip-e94d6380711fa06ac4d235ba1a04d1f53e396216)
* | | | | 6e2e0db64 2017-06-08 02:06:54 Martin Quinson cosmetics (+ sleep at the end of test to avoid problems) (refs/bisect/skip-6e2e0db641d8d3b1147db18d968d30a374290f44)
* | | | | c456536dd 2017-06-08 02:00:38 Martin Quinson improve the debug messages of smx_network (refs/bisect/skip-c456536dd864bba9c136026a9bd44d7f2502df79)
* | | | | bdeb73fa3 2017-06-08 01:59:46 Martin Quinson Correctly deal with simcall returning a intrusive_ptr of nullptr (refs/bisect/skip-bdeb73fa38787af6728f7d01c0f6c0ae73d38b42)
* | | | | c8b31ee6a 2017-06-08 01:54:44 Martin Quinson Make sure that the user don't try a detached receive (refs/bisect/skip-c8b31ee6aba2b75d54acd9c94514d54da16168d6)
* | | | | 69901c51b 2017-06-08 01:54:16 Martin Quinson correct refcounting of ActorPtr (refs/bisect/skip-69901c51b9fbfb0a3e5dbc8a8ac1678adfcb0465)
* | | | | d4996f016 2017-06-08 00:29:34 Martin Quinson Add an exhaustive test for point to point communications (refs/bisect/skip-d4996f01655f56a13547336f71b00f81d99b84fe)
* | | | | 652e6c763 2017-06-07 11:17:05 Martin Quinson further WIP on the ActivityImplPtr feature. Now it compiles (but fails) (refs/bisect/skip-652e6c763d01ad7924087d541928bd44c795d72d)
* | | | | 2f4509c52 2017-06-07 11:13:26 Martin Quinson Declare and use ActorImplPtr (refs/bisect/skip-2f4509c52115b8a4fb4916f51057d6b9314b4c45)
* | | | | 765ca7ac3 2017-06-07 09:20:13 Martin Quinson Reduce the displayed backtrace (refs/bisect/skip-765ca7ac3efd59d260163fa0a7d34ee2eb674f47)
* | | | | d68a0ac23 2017-06-06 08:16:34 Martin Quinson first attempt (ongoing WIP) (refs/bisect/skip-d68a0ac239494f0a1c7f21b7c195f453ee7a31eb)