#1498 Fix remaining warnings not yet covered in library compilation.

Changelog.md

@@ -37,7 +37,7 @@ Gitlab groups).
 and the [Sonar scanner for C++ by the community](https://github.com/SonarOpenCommunity/sonar-cxx).
 - Documentation #1495: Update README concerning CI
 
-- _Standby_: Feature #1497: Add Verrou flaoting-point checks in CI. There is an issue to set it up properly for all VMs (current Docker image works 
+- _Standby_: Feature #1497: Add Verrou floating-point checks in CI. There is an issue to set it up properly for all VMs (current Docker image works 
 properly on only half the VMs of the project).
 
 ## Miscellaneous

Sources/OperatorInstances/VariationalOperator/NonlinearForm/Local/MixedSolidIncompressibility.hxx

@@ -36,16 +36,16 @@ namespace MoReFEM::Advanced::LocalVariationalOperatorNS
 		const auto& elementary_data = GetElementaryData();
 
 		const auto& displacement_ref_felt = elementary_data.GetRefFElt(GetNthUnknown(0));
-		const int Nnode_displacement = static_cast<int>(displacement_ref_felt.Nnode());
+		const auto Nnode_displacement = displacement_ref_felt.Nnode();
 
 		const auto& pressure_ref_felt = elementary_data.GetRefFElt(GetNthUnknown(1));
-		const int Nnode_pressure = static_cast<int>(pressure_ref_felt.Nnode());
+		const auto Nnode_pressure = pressure_ref_felt.Nnode();
 
 		const auto& test_displacement_ref_felt = elementary_data.GetRefFElt(GetNthTestUnknown(0));
-		const int Nnode_test_displacement = static_cast<int>(test_displacement_ref_felt.Nnode());
+		const auto Nnode_test_displacement = test_displacement_ref_felt.Nnode();
 
 		const auto& test_pressure_ref_felt = elementary_data.GetRefFElt(GetNthTestUnknown(1));
-		const int Nnode_test_pressure = static_cast<int>(test_pressure_ref_felt.Nnode());
+		const auto Nnode_test_pressure = test_pressure_ref_felt.Nnode();
 
 		const unsigned int Ncomponent = elementary_data.GetGeomEltDimension();
 		const unsigned int square_Ncomponent = NumericNS::Square(Ncomponent);
@@ -384,8 +384,8 @@ namespace MoReFEM::Advanced::LocalVariationalOperatorNS
 		// Residual on disp
 		for (unsigned int row_component = 0u; row_component < Ncomponent; ++row_component)
 		{
-			const auto dof_first_index = static_cast<int>(test_displacement_ref_felt.GetIndexFirstDofInElementaryData(row_component));
-			const auto component_first_index = static_cast<int>(row_component * Ncomponent);
+			const auto dof_first_index = test_displacement_ref_felt.GetIndexFirstDofInElementaryData(row_component);
+			const auto component_first_index = row_component * Ncomponent;
 
 				// Compute the new contribution to vector_result here.
 				// Product matrix vector is inlined here to avoid creation of an intermediate subset of \a rhs_part.
@@ -401,7 +401,7 @@ namespace MoReFEM::Advanced::LocalVariationalOperatorNS
 		}
 
 		// Residual on pres
-		const auto dof_first_index_pres = static_cast<int>(Nnode_disp * Ncomponent);
+		const auto dof_first_index_pres = Nnode_disp * Ncomponent;
 		for (auto row_node = 0ul; row_node < Nnode_pressure; ++row_node)
 		{
 			vector_result(dof_first_index_pres + row_node) += rhs_pres * weight_meas * test_pressure_phi(row_node);
@@ -458,11 +458,11 @@ namespace MoReFEM::Advanced::LocalVariationalOperatorNS
 		// Tangent disp disp
 		for (unsigned int row_component = 0u; row_component < Ncomponent; ++row_component)
 		{
-			const auto row_first_index = static_cast<int>(test_displacement_ref_felt.GetIndexFirstDofInElementaryData(row_component));
+			const auto row_first_index = test_displacement_ref_felt.GetIndexFirstDofInElementaryData(row_component);
 
 			for (unsigned int col_component = 0u; col_component < Ncomponent; ++col_component)
 			{
-				const auto col_first_index = static_cast<int>(displacement_ref_felt.GetIndexFirstDofInElementaryData(col_component));
+				const auto col_first_index = displacement_ref_felt.GetIndexFirstDofInElementaryData(col_component);
 
 				Advanced::LocalVariationalOperatorNS::ExtractGradientBasedBlock(tangent_matrix_disp_disp,
 																				row_component,
@@ -487,12 +487,12 @@ namespace MoReFEM::Advanced::LocalVariationalOperatorNS
 
 
 		// Tangent disp pres
-		const auto col_first_index_pressure = static_cast<int>(Ncomponent * Nnode_disp);
-		const auto row_first_index_pressure = static_cast<int>(Ncomponent * Nnode_test_disp);
+		const auto col_first_index_pressure = Ncomponent * Nnode_disp;
+		const auto row_first_index_pressure = Ncomponent * Nnode_test_disp;
 
 		for (unsigned int row_component = 0u; row_component < Ncomponent; ++row_component)
 		{
-			const auto row_first_index_disp = static_cast<int>(test_displacement_ref_felt.GetIndexFirstDofInElementaryData(row_component));
+			const auto row_first_index_disp = test_displacement_ref_felt.GetIndexFirstDofInElementaryData(row_component);
 
 			ExtractGradientBasedBlockColumnMatrix(tangent_vector_disp_pres,
 												  row_component,
@@ -522,7 +522,7 @@ namespace MoReFEM::Advanced::LocalVariationalOperatorNS
 		// Tangent pres disp
 		for (unsigned int col_component = 0u; col_component < Ncomponent; ++col_component)
 		{
-			const auto col_first_index_disp = static_cast<int>(displacement_ref_felt.GetIndexFirstDofInElementaryData(col_component));
+			const auto col_first_index_disp = displacement_ref_felt.GetIndexFirstDofInElementaryData(col_component);
 
 			ExtractGradientBasedBlockRowMatrix(tangent_vector_pres_disp,
 											   col_component,

cmake/MoReFEMSettings.cmake

@@ -34,11 +34,9 @@ include(CheckIPOSupported)
 cmake_policy(SET CMP0069 NEW) # Policy concerning IPO support
 
 if (${CMAKE_BUILD_TYPE} STREQUAL "Debug")
-    add_definitions(-DSELDON_CHECK_BOUNDS -DSELDON_CHECK_DIMENSIONS -DDEBUG=1)    
+    add_definitions(-DDEBUG=1)    
 endif()        
  
-add_definitions(-DSELDON_WITH_LAPACK -DSELDON_WITH_BLAS -DSELDON_WITH_COMPILED_LIBRARY)
-
 #add_cxx_compiler_flag("-fvisibility-inlines-hidden")
 #add_cxx_compiler_flag("-fvisibility=default")