Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G g5k-api
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • grid5000grid5000
  • g5k-api
  • Merge requests
  • !92

Correctly handle 'now' and wrong advance reservations in job model

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Samir Noir requested to merge bugs/#13577 into master Jan 06, 2022
  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 4

The job model was parsing the input job reservation date before passing it to the internal OAR API. Parsing exceptions were caught to return nil, so if the date was not parseable ('now' included which is a valid oarsub keyword for advance reservations), resulting of job created as batch and not advance reservations.

This is now fixed by not parsing the date, and by using the regex used by oarsub to validate the advance reservation format (including 'now'). If the format is not valid, an error is returned.

Documentation was also updated to match oarsub behavior.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugs/#13577