Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G g5k-api
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Attention une mise à jour du service Gitlab va être effectuée le mardi 07 février entre 13h30 et 14h00. Cette mise à jour va générer une interruption du service dont nous ne maîtrisons pas complètement la durée mais qui ne devrait pas excéder quelques minutes (habituellement de l'ordre de trois minutes).

  • grid5000grid5000
  • g5k-api
  • Merge requests
  • !11

Corrections for bug reference 5912 complete with unit tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged MARGERY David requested to merge nirvanesque:bugs/#5912 into master Apr 06, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: nirvanesque

Hello,

Please accept proposed corrections to bug ref. 5912.

Please note the following :

  1. The exception handling introduced involves changes in superclass ApplicationController which are reflected in the functions of subclass JobsController. Changes may be required also in sister class DeploymentsController to use / upgrade to new functionalities.
  2. Nevertheless, DeploymentsController unit tests were also checked - no new errors introduced. Mino cosmetic corrections were made to unit test error messages. They have not been committed in this pull request. If needed to introduce, please let me know and I will create a new pull request.
  3. There are other failing unit tests in DeploymentsController (from previous corrections). They can be taken up separately w.r.t any bugs detected for deployments functionalities.

Please let me know if you need further clarifications on this pull request.

Best ! Anirvan

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nirvanesque:bugs/#5912