Skip to content

GitLab

Nous avons procédé ce jeudi matin 08 avril 2021 à une MAJ de sécurité urgente. Nous sommes passé de la version 13.9.3 à la version 13.9.5 les releases notes correspondantes sont ici:
https://about.gitlab.com/releases/2021/03/17/security-release-gitlab-13-9-4-released/
https://about.gitlab.com/releases/2021/03/31/security-release-gitlab-13-10-1-released/

Commit 9d4e5566 authored by François Bobot's avatar François Bobot
Browse files
Options

session_ro : Fix provers handling 

- add the provers list which can be found in the session.
- remove Detected/Undetected since we use only the information
provided by the session, not which provers are currently available
on the current computer.
parent 02536d53
Hide whitespace changes
Inline Side-by-side
Showing with 61 additions and 42 deletions
src/ide/html_session.ml
View file @ 9d4e5566
......@@ -154,9 +154,7 @@ let run_file (context : context) print_session f =
module Simple =
struct
let print_prover fmt = function
| Detected_prover pd -> fprintf fmt "%s" pd.prover_name
| Undetected_prover s -> fprintf fmt "%s" s
let print_prover fmt pd = fprintf fmt "%s" pd.prover_name
let print_proof_status fmt = function
| Undone -> fprintf fmt "Undone"
......@@ -196,7 +194,7 @@ struct
let print_session _name fmt s =
fprintf fmt "<ul>%a</ul>"
(Pp.print_list Pp.newline print_file) s
(Pp.print_list Pp.newline print_file) s.files
let context : context = "<!DOCTYPE html
......@@ -225,9 +223,7 @@ struct
then fprintf fmt "class='verified'"
else fprintf fmt "class='notverified'"
let print_prover fmt = function
| Detected_prover pd -> fprintf fmt "%s" pd.prover_name
| Undetected_prover s -> fprintf fmt "%s" s
let print_prover fmt pd = fprintf fmt "%s" pd.prover_name
let print_proof_status fmt = function
| Undone -> fprintf fmt "<span class='notverified'>Undone</span>"
......@@ -325,7 +321,7 @@ onclick=\"showedited('%s'); return false;\">%a : %a</a></li>@]"
let print_session_aux name fmt s =
fprintf fmt "@[<hov><ul><a href='#'>%s</a>@,%a</ul>@]"
name
(Pp.print_list Pp.newline print_file) s
(Pp.print_list Pp.newline print_file) s.files
let print_session name fmt s =
......
src/ide/session.ml
View file @ 9d4e5566
......@@ -1487,13 +1487,16 @@ available on this computer@."
eprintf "[Warning] Session.load_file: unexpected element '%s'@." s;
old_provers
let old_provers = ref Util.Mstr.empty
let get_old_provers () = !old_provers
let load_session ~env xml =
let cont = xml.Xml.content in
match cont.Xml.name with
| "why3session" ->
let _old_provers =
(** just to keep the old_provers somewhere *)
old_provers :=
List.fold_left (load_file ~env) Util.Mstr.empty cont.Xml.elements
in ()
| s ->
eprintf "[Warning] Session.load_session: unexpected element '%s'@." s
......
src/ide/session.mli
View file @ 9d4e5566
......@@ -210,6 +210,10 @@ module Make(O: OBSERVER) : sig
*)
val get_provers : unit -> prover_data Util.Mstr.t
(** The provers on this computer *)
val get_old_provers : unit -> (string * string) Util.Mstr.t
(** The provers in this session (name * version ) *)
val maximum_running_proofs : int ref
......
src/ide/session_ro.ml
View file @ 9d4e5566
......@@ -25,7 +25,9 @@ open Util
type session = file list
type session =
{ files : file list;
provers : prover_data Mstr.t}
and file =
{ file_name : string;
......@@ -53,21 +55,17 @@ and transf =
and prover_data =
{ prover_name : string;
prover_version : string;
prover_interactive : bool;
(** will be added again when session records it *)
(* prover_interactive : bool; *)
}
and prover_option =
| Detected_prover of prover_data
| Undetected_prover of string
and proof_attempt_status =
| Undone
| Done of Call_provers.prover_result (** external proof done *)
| InternalFailure of exn (** external proof aborted by internal error *)
and proof_attempt =
{ prover : prover_option;
{ prover : prover_data;
proof_state : proof_attempt_status;
timelimit : int;
proof_obsolete : bool;
......@@ -86,6 +84,16 @@ let read_config ?(includes=[]) conf_path_opt =
{env = env; config = config}
let get_provers env =
let provers = Whyconf.get_provers env.config in
let get_prover_data pr =
{ prover_name = pr.Whyconf.name;
prover_version = pr.Whyconf.version;
(* prover_interactive = pr.Whyconf.interactive; *)
}
in
Mstr.map get_prover_data provers
module Observer_dumb : Session.OBSERVER =
struct
type key = unit
......@@ -103,13 +111,16 @@ module Read_project (O : Session.OBSERVER)
struct
module M = Session.Make(Observer_dumb)
let read_prover_option = function
| M.Detected_prover pd -> Detected_prover
{ prover_name = pd.Session.prover_name;
prover_version = pd.Session.prover_version;
prover_interactive = pd.Session.interactive;
}
| M.Undetected_prover s -> Undetected_prover s
let old_provers = ref Mstr.empty
let get_prover_by_id pid =
try Mstr.find pid !old_provers
with Not_found -> assert false (** the provers must be an old_provers *)
let read_prover_option po =
get_prover_by_id (match po with
| M.Detected_prover pd -> pd.Session.prover_id
| M.Undetected_prover s -> s)
let read_attempt_status = function
| Session.Undone | Session.Scheduled | Session.Interrupted
......@@ -167,7 +178,12 @@ struct
let _found_obs = M.open_session ~allow_obsolete
~env:env.env ~config:env.config ~init ~notify P.project_dir
in
List.map read_file (M.get_all_files ())
let prover_data (name,version) =
{ prover_name = name; prover_version = version} in
let op = Mstr.map prover_data (M.get_old_provers ()) in
old_provers := op;
{files = List.map read_file (M.get_all_files ());
provers = op}
end
......
src/ide/session_ro.mli
View file @ 9d4e5566
......@@ -23,7 +23,9 @@
open Why3
open Util
type session = file list
type session =
{ files : file list;
provers : prover_data Mstr.t}
and file = private
{ file_name : string;
......@@ -51,21 +53,17 @@ and transf = private
and prover_data = private
{ prover_name : string;
prover_version : string;
prover_interactive : bool;
(** will be added again when session records it *)
(* prover_interactive : bool; *)
}
and prover_option = private
| Detected_prover of prover_data
| Undetected_prover of string
and proof_attempt_status = private
| Undone
| Done of Call_provers.prover_result (** external proof done *)
| InternalFailure of exn (** external proof aborted by internal error *)
and proof_attempt = private
{ prover : prover_option;
{ prover : prover_data;
proof_state : proof_attempt_status;
timelimit : int;
proof_obsolete : bool;
......@@ -82,6 +80,9 @@ val read_config : ?includes:string list -> string option -> env
[conf_path] or use the default location if [conf_path] is [None].
Add the directory in [includes] in the loadpath *)
val get_provers : env -> prover_data Util.Mstr.t
(** Get the provers on this computer *)
val read_project_dir :
allow_obsolete:bool ->
env:env -> string -> session
......
src/ide/stats.ml
View file @ 9d4e5566
......@@ -170,20 +170,19 @@ let stats_of_file stats file =
let theories = file.theories in
List.iter (stats_of_theory file stats) theories
let fill_prover_data stats =
let provers = Mstr.empty (* FIXME get_provers ()*) in
let fill_prover_data stats session =
Mstr.iter
(fun prover data ->
Hashtbl.add stats.prover_data prover
(data.Session.prover_name ^ " " ^ data.Session.prover_version))
provers
(data.prover_name ^ " " ^ data.prover_version))
session.provers
let extract_stats_from_file stats fname =
let project_dir = get_project_dir fname in
try
let file_list = read_project_dir ~allow_obsolete ~env project_dir in
fill_prover_data stats;
List.iter (stats_of_file stats) file_list
let session = read_project_dir ~allow_obsolete ~env project_dir in
fill_prover_data stats session;
List.iter (stats_of_file stats) session.files
with e when not (Debug.test_flag Debug.stack_trace) ->
eprintf "Error while opening session with database '%s' : %a@." project_dir
Exn_printer.exn_printer e;
......@@ -198,7 +197,7 @@ let finalize_stats stats =
stats.prover_avg_time
let print_stats stats =
printf "== Provers used ==@\n @[";
printf "== Provers available ==@\n @[";
Hashtbl.iter (fun prover data -> printf "%-10s: %s@\n" prover data)
stats.prover_data;
printf "@]@\n";
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment