From cfc2ee84548a1ba1a26fad841ed6eb56652920dc Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Mon, 11 Sep 2017 16:10:12 +0200 Subject: [PATCH 1/7] =?UTF-8?q?dev.org:=20phantomjs=20=E2=86=92=20nightmar?= =?UTF-8?q?e?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We changed that months ago. --- doc/dev.org | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/dev.org b/doc/dev.org index f38a32247..e8a8433ec 100644 --- a/doc/dev.org +++ b/doc/dev.org @@ -283,13 +283,15 @@ The cache is stored for each user and is updated only when a change occurs (mess [[../browser/test/QUnit/testFiles][browser/test/QUnit/testFiles]]. The file [[../browser/test/QUnit/testFiles/data_test.js][data_test.js]] contains a toy dataset that is used in the tests. - Unit tests can be launched using a real browser (instead of phantomjs). It + Unit tests can be launched using a real browser (instead of nightmare). It suffices to open the file [[../browser/test/QUnit/test_Qunit.html][test_Qunit.html]]. In this HTML webpage it is possible to see the coverage. It is important that all possible functions are covered by unit tests. Having the coverage displayed under Firefox needs to display the webpage using a web server for security reasons. Under Chromium/Chrome this should work fine by just opening the webpage. + + Note that using =nightmare= as default requires the installation of =xvfb=. *** Functional **** Architecture -- GitLab From b164a6db57312071216c35a95d4ef00af86a0f4f Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Mon, 11 Sep 2017 16:10:28 +0200 Subject: [PATCH 2/7] server.org: required packages for server --- doc/server.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/server.org b/doc/server.org index 0b625981a..96df10883 100644 --- a/doc/server.org +++ b/doc/server.org @@ -97,7 +97,7 @@ These instructions are preliminary, other documentation can also be found in [[h apt-get install g++ apt-get install make apt-get install unzip - apt-get install enum34 + apt-get install pyhton-pip python-enum34 #+END_SRC ** Vidjil server installation and initialization -- GitLab From 8ea2d33f85e5df526b6ec7d3deebbe7e31ab77a9 Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Mon, 11 Sep 2017 18:21:58 +0200 Subject: [PATCH 3/7] dev.org: How to rollback selenium-webdriver --- doc/dev.org | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/dev.org b/doc/dev.org index e8a8433ec..5ff744daa 100644 --- a/doc/dev.org +++ b/doc/dev.org @@ -353,8 +353,16 @@ gem install test-unit #+END_SRC This may install a =selenium-webdriver= gem whose version is ≥ 3. We highly -recommend that you force an install to a version < 3 (/e.g./ 2.53.4). However -the webdriver may not work with recent versions of Firefox (> 45). +recommend that you force an install to a version < 3 (/e.g./ 2.53.4). + +#+BEGIN_SRC sh +# Removing a new version of selenium-webdriver +gem uninstall selenium-webdriver +# Installing an older version +gem install selenium-webdriver -v 2.53.4 +#+END_SRC + +However the webdriver may not work with recent versions of Firefox (> 45). **** Launch browser tests -- GitLab From bb872cabe30ba55514372e83aef80f82a77a085b Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Mon, 11 Sep 2017 18:22:24 +0200 Subject: [PATCH 4/7] dev.org: Downgrading Firefox --- doc/dev.org | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/dev.org b/doc/dev.org index 5ff744daa..795857f66 100644 --- a/doc/dev.org +++ b/doc/dev.org @@ -362,7 +362,10 @@ gem uninstall selenium-webdriver gem install selenium-webdriver -v 2.53.4 #+END_SRC -However the webdriver may not work with recent versions of Firefox (> 45). +However the webdriver may not work with recent versions of Firefox (> 45). In +such a case you would like to downgrade your Firefox version or use a former +version. The Firefox version used can be set with an environment variable (see +below). All Firefox releases are [[https://download-installer.cdn.mozilla.net/pub/firefox/releases/ ][available here]]. **** Launch browser tests -- GitLab From 68db1169ae2986e7fea57c6832ce08c17c021add Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Mon, 11 Sep 2017 19:25:26 +0200 Subject: [PATCH 5/7] server.org: typo --- doc/server.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/server.org b/doc/server.org index 96df10883..02d8017e9 100644 --- a/doc/server.org +++ b/doc/server.org @@ -97,7 +97,7 @@ These instructions are preliminary, other documentation can also be found in [[h apt-get install g++ apt-get install make apt-get install unzip - apt-get install pyhton-pip python-enum34 + apt-get install python-pip python-enum34 #+END_SRC ** Vidjil server installation and initialization -- GitLab From eb22fc69c3fad8eb186ca4e22116908ee167a4c1 Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Tue, 12 Sep 2017 08:36:42 +0200 Subject: [PATCH 6/7] dev.org: more info on installing nightmare --- doc/dev.org | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/dev.org b/doc/dev.org index 795857f66..bcdbc8269 100644 --- a/doc/dev.org +++ b/doc/dev.org @@ -291,7 +291,16 @@ The cache is stored for each user and is updated only when a change occurs (mess reasons. Under Chromium/Chrome this should work fine by just opening the webpage. - Note that using =nightmare= as default requires the installation of =xvfb=. +**** Installation + Nightmare is distributed withing =node= and can therefore be installed with it. + + #+BEGIN_SRC sh + apt-get install nodejs npm + npm install nightmare + #+END_SRC + + Note that using =nightmare= for our unit testing + requires the installation of =xvfb=. *** Functional **** Architecture -- GitLab From a28664a560269aaa6be82a82ea9372c2227d80ae Mon Sep 17 00:00:00 2001 From: Mikael Salson Date: Tue, 12 Sep 2017 11:44:25 +0200 Subject: [PATCH 7/7] light.css: A great green anis menu color --- browser/css/light.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/css/light.css b/browser/css/light.css index 1d4d11170..f722cf02c 100644 --- a/browser/css/light.css +++ b/browser/css/light.css @@ -53,7 +53,7 @@ ul { #top-container { height: 32px; width: 100%; - background: #ffffff; + background: #9fe855; position: fixed; z-index: 1; } -- GitLab