GitLab

the variable pos was defined twice and raised a JSHint error.

it would seem the value parameter of addLabel is not, or is no longer
used in germline_axis, although it is needed with the new mapping and
converter system.

the changes to the position of the undefined values altered the position
of the values and the tests need to be adapted.

this global variable was converted to a class attribute, and needs to be
referenced thusly.

Prevent security issues where an attacker could try to view other files.

Fix #2404

The numerical axis undefined values were positioned as the lowest
value, whereas for other Axis classes the undefined values are placed as
the highest.

So semantically all axes should behave in the same manner.

Not only is the code more elegant, but with the changes to the
functionning or the GermlineAxis, the allele axes bar charts were no
longer functionning.
Using the label_mapping keys rather than the label text produces the
same result for GenericAxis, but in the GermlineAxis, when using
alleles, the label_mapping keys for alleles contains the complete gene
name whereas the text only contains the allele reference.

The GenericAxis constructor changed with the addition of the 'reverse'
parameter so we need to add said parameter when calling it.

Alleles were broken with the previous refactoring of the converter
method.

The posBarLabel was not appropriate for the GermlineAxis class and
returned incorrect positions.

With the changes to addLabel, the converter method can be reduced to
function much in the same way the converter for the other Axis classes.

The method was not in alignment with the GenericAxis.

tab variable no longer exists, this.value_mapping is the correct way to
reference the desired variable.

use index-based value mapping rather than the converted value.
The main motivation behind this change is to apply the Liskov principle
on posBarLabel.

use the value mapping as the length reference when computing labels for
barchars.

See #2375

posBarLabel is the method used to position the labels for barcharts, so
it should also be used for positionning elements for barcharts.

See #2375

See #2375

JSHint indicates that comparisons to null should be done with '===' and
'!==' therefore, using '==' to factor in equality to 'undefined' is
considered poor practice.

Therefore extending these comparisons to comply with JSHint standards
required it was required to include the comparison of the type of the
variable to the string 'undefined'

the constant variabled used in the axis classes serve just as well as
class attributes, and don't raise the question of ES versions.

JSHint didn't like the expression as a negative of a modulo expression.

A comma was placed instead of a semicolon.

All functions defined in loops are now defined outside of loops.