GitLab

Mathieu Giraud authored Sep 22, 2017 and Ryan Herbert committed Oct 05, 2017

Should be different than actual tags.

This is for auto_completion in the search bar, we want admins to have
access to all tags, and not just the tags from groups they are involved
in

This feels pretty dirty, but it achieves a usage of tags which if
coherent with the usage of the such bar, which is to search for elements
containing all parts of the search.

See #2620

Previously TagExtractor.parse_text would return all matches, including
duplicates, and would therefore potentially link a tag to a set or
sample multiple times (if used mutiple times in the info field).

This commit ensures tags are extracted only once, but will not affect
the link in the frontend

The ... operator is a little too recent and will not work in some
browsers for this usage, notably, Firefox older than 55, Edge, IE,
Opera and Safari

See #2625

Samples had not been updated to include multiple groups, this commit not
only served to fix this, but also takes the opportunity to include all
the involved groups when auto-completing samples

see #2624

See #2621

This one is aimed at the tag auto-completion system. Retrieves all
group memberships for this user as well as their parent groups

instead of passing auth as a parameter, it can be retrieved using
current

tags can now be queried and auto-completed by multiple group_ids. This
is in order to better manage tag auto-completion for samples added to multiple groups as well as auto-completion for search bars

See #2622

Tag searching is now managed in the search box entirely. The contents is
filtered and separated into tags and search strings in order to provide
an easier way for users to manipulate tags and filter results in a
seamless manner.

adds the target-param value to the url to specify that name of the
parameter that should be used in the url

the object is to filter the search bar and and extract tags from
searches

in order to pass special characters in the URI such as tag prefixes, we
need to encore the characters correctly. Otherwise the parameter simply
gets ignored.

In an attempt to make to more apparent that sample_sets have been
filtered by tag, we now display the tag in the filter search bar in a
way that will not impede any further searches performed by the user.

See #2619

It would seem some systems have a limit to the size a unique varchar can
be. This issue was preventing the use of the application due to the
databse rejecting the creation of the table.

refactores the url sanitisation to the TagDecorator, since we had a
little code duplication

renaming decorate_text to decorate slighlty reduces the length of lines
while remaining sufficiently clear as to the purpose of the function, I
believe.

This is to give access to web2py HTML helpers for some refactoring

only get the group_id if the description has changed. The group_id is
only used by the tag registration in the route, so it makes sense to
save a query if no tags are going to be registered.

The decorated sample tags were implemented to redirect to
'/sample_set/custom' while passing the tag as a parameter, so now this
parameter will be taken into account and only display samples that have
said tag

Although the jquery plugin autocomplete.js was providing the basic
functionnality we needed, it was not natively able to display the list
of suggestions in the desired position for our textareas.

At.js is capable through the use of Caret.js of displaying a suggestion
box under the caret in a textarea.

This javascript code is heavily inspired by the code present in the
gitlab-ce project and allows us to have a nicely cached data-set to
limit database queries.

The group_id had previously been committed as a hard-coded value, thus
locking the completion to a single group. Obviously we want completion
to work for everyone, so this will achieve our goal.

autocomplete.js contains a binding function to bind the autocomplete
library to a DOM element.

The views then call this function when they are focused

This is the proper way of removing the tag prefix from the query

takes a tag name and a group id and returns a list of tags in json
format