Mentions légales du service

Skip to content

Add condition on which renderer is used to include headers

Philippe SWARTVAGHER requested to merge pswartva/vite:fix-vulkan-include into master

Otherwise it triggers a build error if Vulkan headers are not found (for instance).

Bug was introduced by commit 86ae6eeb.

FTR, bug found when trying to build ViTE from the master branch with Guix:

guix build vite --with-branch=vite=master
In file included from /gnu/store/glrh81xfa4ahp8dg7jji0fg4nijg0b2k-qtbase-5.15.10/include/qt5/QtGui/qvulkanwindow.h:51,
                 from /gnu/store/glrh81xfa4ahp8dg7jji0fg4nijg0b2k-qtbase-5.15.10/include/qt5/QtGui/QVulkanWindow:1,
                 from /tmp/guix-build-vite-git.master.drv-0/source/src/render/vulkan/Vulkan_window.hpp:42,
                 from /tmp/guix-build-vite-git.master.drv-0/source/src/render/vulkan/Render_vulkan.hpp:44,
                 from /tmp/guix-build-vite-git.master.drv-0/source/src/interface/Interface_graphic.cpp:91:
/gnu/store/glrh81xfa4ahp8dg7jji0fg4nijg0b2k-qtbase-5.15.10/include/qt5/QtGui/qvulkaninstance.h:55:10: fatal error: vulkan/vulkan.h: No such file or directory
   55 | #include <vulkan/vulkan.h>
      |          ^~~~~~~~~~~~~~~~~

When using this patch, it works fine. Just look at the beauty of Guix's package transformations:

guix build vite --with-branch=vite=master --with-patch=vite=vulkan.patch

😄

Merge request reports