Apply patch 2 from issue #13

src/common/Message.cpp

@@ -91,9 +91,7 @@ const Message::end_information_t Message::endi;
 const Message::end_selection_information_t Message::endsi;
 #endif
 
-Message::Message() {
-
-}
+Message::Message() = default;
 
 Message *Message::get_instance() {
     if (_message)

src/interface/Interval_select.cpp

@@ -90,8 +90,7 @@ Interval_select::Interval_select(Interface_graphic * console,QWidget *parent) :
     _applied      = false;
 }
 
-Interval_select::~Interval_select() {
-}
+Interval_select::~Interval_select() = default;
 
 Trace* Interval_select::get_trace() {
     return _trace;

src/interface/Node_select.cpp

@@ -87,8 +87,7 @@ Node_select::Node_select(Interface_graphic * console,QWidget *parent) : QWidget(
     QMetaObject::connectSlotsByName(nullptr);
 }
 
-Node_select::~Node_select() {
-}
+Node_select::~Node_select() = default;
 
 void Node_select::set_initial_container_names(){
 

src/interface/Settings_window.cpp

@@ -526,8 +526,7 @@ Settings_window::Settings_window(Core *c, QWidget *parent)
     tabWidget->insertTab(3, _tab_links, "Links");
 }
 
-Settings_window::~Settings_window() {
-}
+Settings_window::~Settings_window() = default;
 
 void Settings_window::on_tabWidget_currentChanged(int ) {
 

src/interface/qxtpimpl.h

-/****************************************************************************
-**
-** Copyright (C) Adam Higerd <coda@bobandgeorge.com>. Some rights reserved.
-**
-** This file is part of the QxtCore module of the
-** Qt eXTension library <http://libqxt.sourceforge.net>
-**
-** This library is free software; you can redistribute it and/or
-** modify it under the terms of the GNU Lesser General Public
-** License as published by the Free Software Foundation; either
-** version 2.1 of the License, or any later version.
-**
-** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
-** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-**
-** There is aditional information in the LICENSE file of libqxt.
-** If you did not receive a copy of the file try to download it or
-** contact the libqxt Management
-**
-****************************************************************************/
-/**
-\class QxtPimpl QxtPimpl
-\ingroup core
-\brief Hide private details of a class
-
-Application code generally doesn't have to be concerned about hiding its
-implementation details, but when writing library code it is important to
-maintain a constant interface, both source and binary. Maintaining a constant
-source interface is easy enough, but keeping the binary interface constant
-means moving implementation details into a private class. The PIMPL, or
-d-pointer, idiom is a common method of implementing this separation. QxtPimpl
-offers a convenient way to connect the public and private sides of your class.
-
-\section start Getting Started
-Before you declare the public class, you need to make a forward declaration
-of the private class. The private class must have the same name as the public
-class, followed by the word Private. For example, a class named MyTest would
-declare the private class with:
-\code
-class MyTestPrivate;
-\endcode
-
-\subsection pub The Public Class
-Generally, you shouldn't keep any data members in the public class without a
-good reason. Functions that are part of the public interface should be declared
-in the public class, and functions that need to be available to subclasses (for
-calling or overriding) should be in the protected section of the public class.
-To connect the private class to the public class, include the
-QXT_DECLARE_PRIVATE macro in the private section of the public class. In the
-example above, the private class is connected as follows:
-\code
-private:
-    QXT_DECLARE_PRIVATE(MyTest);
-\endcode
-
-Additionally, you must include the QXT_INIT_PRIVATE macro in the public class's
-constructor. Continuing with the MyTest example, your constructor might look
-like this:
-\code
-MyTest::MyTest() {
-    // initialization
-    QXT_INIT_PRIVATE(MyTest);
-}
-\endcode
-
-\subsection priv The Private Class
-As mentioned above, data members should usually be kept in the private class.
-This allows the memory layout of the private class to change without breaking
-binary compatibility for the public class. Functions that exist only as
-implementation details, or functions that need access to private data members,
-should be implemented here.
-
-To define the private class, inherit from the template QxtPrivate class, and
-include the QXT_DECLARE_PUBLIC macro in its public section. The template
-parameter should be the name of the public class. For example:
-\code
-class MyTestPrivate : public QxtPrivate<MyTest> {
-public:
-    MyTestPrivate();
-    QXT_DECLARE_PUBLIC(MyTest);
-};
-\endcode
-
-\section cross Accessing Private Members
-Use the qxt_d() function (actually a function-like object) from functions in
-the public class to access the private class. Similarly, functions in the
-private class can invoke functions in the public class by using the qxt_p()
-function (this one's actually a function).
-
-For example, assume that MyTest has methods named getFoobar and doBaz(),
-and MyTestPrivate has a member named foobar and a method named doQuux().
-The code might resemble this example:
-\code
-int MyTest::getFoobar() {
-    return qxt_d().foobar;
-}
-
-void MyTestPrivate::doQuux() {
-    qxt_p().doBaz(foobar);
-}
-\endcode
-*/
-
-#ifndef QXTPIMPL_H
-#define QXTPIMPL_H
-
-/*! \relates QxtPimpl
- * Declares that a public class has a related private class.
- *
- * This shuold be put in the private section of the public class. The parameter is the name of the public class.
- */
-#define QXT_DECLARE_PRIVATE(PUB) friend class PUB##Private; QxtPrivateInterface<PUB, PUB##Private> qxt_d;
-/*! \relates QxtPimpl
- * Declares that a private class has a related public class.
- *
- * This may be put anywhere in the declaration of the private class. The parameter is the name of the public class.
- */
-#define QXT_DECLARE_PUBLIC(PUB) friend class PUB;
-/*! \relates QxtPimpl
- * Initializes resources owned by the private class.
- *
- * This should be called from the public class's constructor,
- * before qxt_d() is used for the first time. The parameter is the name of the public class.
- */
-#define QXT_INIT_PRIVATE(PUB) qxt_d.setPublic(this);
-
-#ifdef QXT_DOXYGEN_RUN
-/*! \relates QxtPimpl
- * Returns a reference to the private class.
- *
- * This function is only available in a class using \a QXT_DECLARE_PRIVATE.
- */
-QxtPrivate<PUB>& qxt_d();
-
-/*! \relates QxtPimpl
- * Returns a const reference to the private class.
- *
- * This function is only available in a class using \a QXT_DECLARE_PRIVATE.
- * This overload will be automatically used in const functions.
- */
-const QxtPrivate<PUB>& qxt_d();
-
-/*! \relates QxtPimpl
- * Returns a reference to the public class.
- *
- * This function is only available in a class using \a QXT_DECLARE_PUBLIC.
- */
-PUB& qxt_p();
-
-/*! \relates QxtPimpl
- * Returns a const reference to the public class.
- *
- * This function is only available in a class using \a QXT_DECLARE_PUBLIC.
- * This overload will be automatically used in const functions.
- */
-const PUB& qxt_p();
-#endif
-
-#ifndef QXT_DOXYGEN_RUN
-template <typename PUB>
-class QxtPrivate {
-public:
-    virtual ~QxtPrivate() {}
-    inline void QXT_setPublic(PUB* pub) { qxt_p_ptr = pub; }
-
-protected:
-    inline PUB& qxt_p() { return *qxt_p_ptr; }
-    inline const PUB& qxt_p() const { return *qxt_p_ptr; }
-
-private:
-    PUB* qxt_p_ptr;
-};
-
-template <typename PUB, typename PVT>
-class QxtPrivateInterface {
-friend class QxtPrivate<PUB>;
-public:
-    QxtPrivateInterface() { pvt = new PVT; }
-    ~QxtPrivateInterface() { delete pvt; }
-
-    inline void setPublic(PUB* pub) { pvt->QXT_setPublic(pub); }
-    inline PVT& operator()() { return *static_cast<PVT*>(pvt); }
-    inline const PVT& operator()() const { return *static_cast<PVT*>(pvt); }
-private:
-    QxtPrivate<PUB>* pvt;
-};
-#endif
-
-#endif
\ No newline at end of file
+/****************************************************************************
+ **
+ ** Copyright (C) Adam Higerd <coda@bobandgeorge.com>. Some rights reserved.
+ **
+ ** This file is part of the QxtCore module of the
+ ** Qt eXTension library <http://libqxt.sourceforge.net>
+ **
+ ** This library is free software; you can redistribute it and/or
+ ** modify it under the terms of the GNU Lesser General Public
+ ** License as published by the Free Software Foundation; either
+ ** version 2.1 of the License, or any later version.
+ **
+ ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
+ ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
+ **
+ ** There is aditional information in the LICENSE file of libqxt.
+ ** If you did not receive a copy of the file try to download it or
+ ** contact the libqxt Management
+ **
+ ****************************************************************************/
+/**
+ \class QxtPimpl QxtPimpl
+ \ingroup core
+ \brief Hide private details of a class
+
+ Application code generally doesn't have to be concerned about hiding its
+ implementation details, but when writing library code it is important to
+ maintain a constant interface, both source and binary. Maintaining a constant
+ source interface is easy enough, but keeping the binary interface constant
+ means moving implementation details into a private class. The PIMPL, or
+ d-pointer, idiom is a common method of implementing this separation. QxtPimpl
+ offers a convenient way to connect the public and private sides of your class.
+
+ \section start Getting Started
+ Before you declare the public class, you need to make a forward declaration
+ of the private class. The private class must have the same name as the public
+ class, followed by the word Private. For example, a class named MyTest would
+ declare the private class with:
+ \code
+ class MyTestPrivate;
+ \endcode
+
+ \subsection pub The Public Class
+ Generally, you shouldn't keep any data members in the public class without a
+ good reason. Functions that are part of the public interface should be declared
+ in the public class, and functions that need to be available to subclasses (for
+ calling or overriding) should be in the protected section of the public class.
+ To connect the private class to the public class, include the
+ QXT_DECLARE_PRIVATE macro in the private section of the public class. In the
+ example above, the private class is connected as follows:
+ \code
+ private:
+ QXT_DECLARE_PRIVATE(MyTest);
+ \endcode
+
+ Additionally, you must include the QXT_INIT_PRIVATE macro in the public class's
+ constructor. Continuing with the MyTest example, your constructor might look
+ like this:
+ \code
+ MyTest::MyTest() {
+ // initialization
+ QXT_INIT_PRIVATE(MyTest);
+ }
+ \endcode
+
+ \subsection priv The Private Class
+ As mentioned above, data members should usually be kept in the private class.
+ This allows the memory layout of the private class to change without breaking
+ binary compatibility for the public class. Functions that exist only as
+ implementation details, or functions that need access to private data members,
+ should be implemented here.
+
+ To define the private class, inherit from the template QxtPrivate class, and
+ include the QXT_DECLARE_PUBLIC macro in its public section. The template
+ parameter should be the name of the public class. For example:
+ \code
+ class MyTestPrivate : public QxtPrivate<MyTest> {
+ public:
+ MyTestPrivate();
+ QXT_DECLARE_PUBLIC(MyTest);
+ };
+ \endcode
+
+ \section cross Accessing Private Members
+ Use the qxt_d() function (actually a function-like object) from functions in
+ the public class to access the private class. Similarly, functions in the
+ private class can invoke functions in the public class by using the qxt_p()
+ function (this one's actually a function).
+
+ For example, assume that MyTest has methods named getFoobar and doBaz(),
+ and MyTestPrivate has a member named foobar and a method named doQuux().
+ The code might resemble this example:
+ \code
+ int MyTest::getFoobar() {
+ return qxt_d().foobar;
+ }
+
+ void MyTestPrivate::doQuux() {
+ qxt_p().doBaz(foobar);
+ }
+ \endcode
+ */
+
+#ifndef QXTPIMPL_H
+#define QXTPIMPL_H
+
+/*! \relates QxtPimpl
+ * Declares that a public class has a related private class.
+ *
+ * This shuold be put in the private section of the public class. The parameter is the name of the public class.
+ */
+#define QXT_DECLARE_PRIVATE(PUB) friend class PUB##Private; QxtPrivateInterface<PUB, PUB##Private> qxt_d;
+/*! \relates QxtPimpl
+ * Declares that a private class has a related public class.
+ *
+ * This may be put anywhere in the declaration of the private class. The parameter is the name of the public class.
+ */
+#define QXT_DECLARE_PUBLIC(PUB) friend class PUB;
+/*! \relates QxtPimpl
+ * Initializes resources owned by the private class.
+ *
+ * This should be called from the public class's constructor,
+ * before qxt_d() is used for the first time. The parameter is the name of the public class.
+ */
+#define QXT_INIT_PRIVATE(PUB) qxt_d.setPublic(this);
+
+#ifdef QXT_DOXYGEN_RUN
+/*! \relates QxtPimpl
+ * Returns a reference to the private class.
+ *
+ * This function is only available in a class using \a QXT_DECLARE_PRIVATE.
+ */
+QxtPrivate<PUB>& qxt_d();
+
+/*! \relates QxtPimpl
+ * Returns a const reference to the private class.
+ *
+ * This function is only available in a class using \a QXT_DECLARE_PRIVATE.
+ * This overload will be automatically used in const functions.
+ */
+const QxtPrivate<PUB>& qxt_d();
+
+/*! \relates QxtPimpl
+ * Returns a reference to the public class.
+ *
+ * This function is only available in a class using \a QXT_DECLARE_PUBLIC.
+ */
+PUB& qxt_p();
+
+/*! \relates QxtPimpl
+ * Returns a const reference to the public class.
+ *
+ * This function is only available in a class using \a QXT_DECLARE_PUBLIC.
+ * This overload will be automatically used in const functions.
+ */
+const PUB& qxt_p();
+#endif
+
+#ifndef QXT_DOXYGEN_RUN
+template <typename PUB>
+class QxtPrivate {
+  public:
+    virtual ~QxtPrivate() = default;
+    inline void QXT_setPublic(PUB* pub) { qxt_p_ptr = pub; }
+
+  protected:
+    inline PUB& qxt_p() { return *qxt_p_ptr; }
+    inline const PUB& qxt_p() const { return *qxt_p_ptr; }
+
+  private:
+    PUB* qxt_p_ptr;
+};
+
+template <typename PUB, typename PVT>
+    class QxtPrivateInterface {
+    friend class QxtPrivate<PUB>;
+  public:
+    QxtPrivateInterface() { pvt = new PVT; }
+    ~QxtPrivateInterface() { delete pvt; }
+
+    inline void setPublic(PUB* pub) { pvt->QXT_setPublic(pub); }
+    inline PVT& operator()() { return *static_cast<PVT*>(pvt); }
+    inline const PVT& operator()() const { return *static_cast<PVT*>(pvt); }
+  private:
+    QxtPrivate<PUB>* pvt;
+};
+#endif
+
+#endif

src/interface/qxtspanslider.cpp

@@ -416,9 +416,7 @@ QxtSpanSlider::QxtSpanSlider(Qt::Orientation orientation, QWidget* parent) : QSl
 /*!
     Destructs the span slider.
  */
-QxtSpanSlider::~QxtSpanSlider()
-{
-}
+QxtSpanSlider::~QxtSpanSlider() = default;
 
 /*!
     \property QxtSpanSlider::handleMovementMode

src/interface/viteqtreewidget.cpp

@@ -12,8 +12,7 @@ viteQTreeWidget::viteQTreeWidget(QWidget *parent)
  
 }
 
-    viteQTreeWidget::~viteQTreeWidget(){
-}
+    viteQTreeWidget::~viteQTreeWidget() = default;
 
 void viteQTreeWidget::dropEvent(QDropEvent *e){
 

src/parser/PajeParser/PajeFileManager.hpp

@@ -85,7 +85,7 @@ typedef struct PajeLine {
     int    _nbtks;
     char **_tokens;
 
-    PajeLine() {}
+    PajeLine() = default;
 } PajeLine_t;
 
 

src/parser/PajeParser/ParserVite.cpp

@@ -69,9 +69,9 @@
 /* -- */
 using namespace std;
 
-ParserVite::ParserVite() {}
+ParserVite::ParserVite() = default;
 ParserVite::ParserVite(const std::string &filename) : Parser(filename) {}
-ParserVite::~ParserVite() {}
+ParserVite::~ParserVite() = default;
 
 void ParserVite::parse(Trace &trace,
                        bool   finish_trace_after_parse){

src/parser/Parser.hpp

@@ -78,7 +78,7 @@ public:
 
     Parser();
     Parser(const std::string &filename);
-    virtual ~Parser() {};
+    virtual ~Parser() = default;
 
     /*!
      *  \fn parse(const std::string &filename, Trace &trace, bool finish_trace_after_parse = true)

src/render/GanttDiagram.hpp

@@ -99,8 +99,7 @@ private:
      * \brief The default constructor is in private scope to prevent Render instanciation without
      * provide a drawing instance.
      */
-    GanttDiagram(){
-    }
+    GanttDiagram() = default;
 
 public:
 
@@ -120,8 +119,7 @@ public:
     /*!
      * \brief The destructor
      */
-    virtual ~GanttDiagram(){
-    }
+    virtual ~GanttDiagram() = default;
 
     /***********************************
      *

src/render/Geometry.cpp

@@ -85,8 +85,7 @@ Geometry::Geometry(){
 }
 
 
-Geometry::~Geometry(){
-}
+Geometry::~Geometry() = default;
 
 
 

src/render/Hook_event.cpp

@@ -179,8 +179,7 @@ Hook_event::Hook_event(Render* render_instance, Core* core, QWidget *parent, con
 }
 
 
-Hook_event::~Hook_event(){
-}
+Hook_event::~Hook_event() = default;
 
 
 

src/render/Ruler.hpp

@@ -61,7 +61,7 @@ private:
     /*!
      * \brief The default constructor. In private scope to prevent instance.
      */
-    Ruler(){}
+    Ruler() = default;
 
     /***********************************
      *

src/render/render_stats_svg.cpp

@@ -62,8 +62,7 @@ Render_stats_svg::Render_stats_svg(string filename){
     _y_max = 0;
 }
 
-Render_stats_svg::~Render_stats_svg(){
-}
+Render_stats_svg::~Render_stats_svg() = default;
 
 
 void Render_stats_svg::set_total_height(Element_pos h) {

src/statistics/DrawCounter.hpp

@@ -90,8 +90,7 @@ public:
     /*!
      * \brief The destructor
      */
-    virtual ~DrawCounter() {
-    }
+    virtual ~DrawCounter() = default;
 
 
     /*!

src/statistics/DrawHDiagram.hpp

@@ -86,8 +86,7 @@ public:
     /*!
      * \brief The destructor
      */
-    virtual ~DrawHDiagram() {
-    }
+    virtual ~DrawHDiagram() = default;
 
 
     /*!

src/statistics/DrawStats.hpp

@@ -155,8 +155,7 @@ public:
     /*!
      * \brief The destructor
      */
-    virtual ~DrawStats() {
-    }
+    virtual ~DrawStats() = default;
 
 
     /*!

src/statistics/DrawVDiagram.hpp

@@ -67,8 +67,7 @@ public:
     /*!
      * \brief The destructor
      */
-    virtual ~DrawVDiagram() {
-    }
+    virtual ~DrawVDiagram() = default;
 
 
     /*!

src/trace/DrawTrace.hpp

@@ -172,8 +172,7 @@ public:
     /*!
      * \brief The destructor
      */
-    virtual ~DrawTrace() {
-    }
+    virtual ~DrawTrace() = default;
 
     /***********************************
      *

src/trace/State.cpp

@@ -58,8 +58,7 @@ State::State(Date start, Date end, StateType *type, Container *container, Entity
 
 }
 
-State::State() {
-}
+State::State() = default;
 
 Date State::get_start_time() const {
     return _start;

src/trace/StateChange.cpp

@@ -53,9 +53,7 @@
 /* -- */
 using namespace std;
 
-StateChange::StateChange() {
-
-}
+StateChange::StateChange() = default;
 
 StateChange::StateChange(Date time): _time(time) {
 

src/trace/values/Value.hpp

@@ -64,7 +64,7 @@ protected:
 
 public:
 
-    virtual ~Value(){};
+    virtual ~Value() = default;
 
     /*!
      *