Mentions légales du service

Skip to content
Snippets Groups Projects
Commit f77bf06c authored by Mathieu Faverge's avatar Mathieu Faverge
Browse files

sonarqube: add protection on NULL parameters to remove sonarqube issues

parent 7f997776
No related branches found
No related tags found
1 merge request!375Sonarqube: Fix a bunch of small bugs and code smells
...@@ -179,6 +179,15 @@ chameleon_starpu_tag_release( int64_t min ) ...@@ -179,6 +179,15 @@ chameleon_starpu_tag_release( int64_t min )
current = current->next; current = current->next;
} }
if ( current == NULL ) {
#if defined(CHAMELEON_DEBUG_STARPU)
fprintf( stderr, "chameleon_starpu_tag: FAILED to release [%ld,...] no set registered with this min value\n",
min );
#endif
return;
}
assert( current != NULL ); assert( current != NULL );
assert( current->min == min ); assert( current->min == min );
...@@ -212,7 +221,7 @@ chameleon_starpu_tag_release( int64_t min ) ...@@ -212,7 +221,7 @@ chameleon_starpu_tag_release( int64_t min )
* @retval TODO * @retval TODO
* *
******************************************************************************/ ******************************************************************************/
int void
chameleon_starpu_tag_init( ) { chameleon_starpu_tag_init( ) {
return CHAMELEON_SUCCESS; return CHAMELEON_SUCCESS;
} }
......
...@@ -152,7 +152,7 @@ typedef struct starpu_option_request_s { ...@@ -152,7 +152,7 @@ typedef struct starpu_option_request_s {
/** /**
* MPI tag management * MPI tag management
*/ */
int chameleon_starpu_tag_init( ); void chameleon_starpu_tag_init( );
int64_t chameleon_starpu_tag_book( int64_t nbtags ); int64_t chameleon_starpu_tag_book( int64_t nbtags );
void chameleon_starpu_tag_release( int64_t min ); void chameleon_starpu_tag_release( int64_t min );
......
...@@ -305,7 +305,13 @@ void ...@@ -305,7 +305,13 @@ void
parameters_read( parameter_t *param, parameters_read( parameter_t *param,
const char *values ) const char *values )
{ {
int range = (values != NULL) && ( strchr( values, ':' ) != NULL ); int range;
if ( values == NULL ) {
fprintf( stderr, "Error passing NULL parameter to read\n" );
exit(EXIT_FAILURE);
}
range = (values != NULL) && ( strchr( values, ':' ) != NULL );
/* If we have a ranged of integer values */ /* If we have a ranged of integer values */
if ( range ) if ( range )
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment