From d712363993a1bc620dae27aa53826321a60103a9 Mon Sep 17 00:00:00 2001
From: Mathieu Faverge <mathieu.faverge@inria.fr>
Date: Tue, 20 Mar 2018 11:12:18 +0100
Subject: [PATCH] Fix another round of sonarqube issues in timings
---
timing/time_zgemm_tile.c | 3 +++
timing/time_zgesvd_tile.c | 16 ++++++++--------
timing/time_zlange_tile.c | 3 ++-
timing/timing.c | 1 -
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/timing/time_zgemm_tile.c b/timing/time_zgemm_tile.c
index 4936a1a1f..ae504b8bc 100644
--- a/timing/time_zgemm_tile.c
+++ b/timing/time_zgemm_tile.c
@@ -48,6 +48,9 @@ RunTest(int *iparam, double *dparam, morse_time_t *t_)
#if !defined(CHAMELEON_SIMULATION)
LAPACKE_zlarnv_work(1, ISEED, 1, &alpha);
LAPACKE_zlarnv_work(1, ISEED, 1, &beta);
+#else
+ alpha = 1.5;
+ beta = -2.3;
#endif
/* Save C for check */
diff --git a/timing/time_zgesvd_tile.c b/timing/time_zgesvd_tile.c
index b7c8f2e86..4f207aeb6 100644
--- a/timing/time_zgesvd_tile.c
+++ b/timing/time_zgesvd_tile.c
@@ -36,7 +36,7 @@ RunTest(int *iparam, double *dparam, morse_time_t *t_)
/* Allocate Data */
PASTE_CODE_ALLOCATE_MATRIX_TILE( descA, 1, MORSE_Complex64_t, MorseComplexDouble, LDA, M, N );
PASTE_CODE_ALLOCATE_MATRIX( VT, (jobvt == MorseVec), MORSE_Complex64_t, N, N );
- PASTE_CODE_ALLOCATE_MATRIX( U, (jobu == MorseVec), MORSE_Complex64_t, M, M );
+ PASTE_CODE_ALLOCATE_MATRIX( U, (jobu == MorseVec), MORSE_Complex64_t, M, M );
PASTE_CODE_ALLOCATE_MATRIX( S, 1, double, N, 1 );
/* Initialiaze Data */
@@ -46,7 +46,7 @@ RunTest(int *iparam, double *dparam, morse_time_t *t_)
MORSE_Alloc_Workspace_zgesvd(N, N, &descT, 1, 1);
if ( jobu == MorseVec ) {
- LAPACKE_zlaset_work(LAPACK_COL_MAJOR, 'A', M, M, 0., 1., U, M);
+ LAPACKE_zlaset_work(LAPACK_COL_MAJOR, 'A', M, M, 0., 1., U, M);
}
if ( jobvt == MorseVec ) {
LAPACKE_zlaset_work(LAPACK_COL_MAJOR, 'A', N, N, 0., 1., VT, N);
@@ -56,18 +56,18 @@ RunTest(int *iparam, double *dparam, morse_time_t *t_)
INFO = MORSE_zgesvd_Tile(jobu, jobvt, descA, S, descT, U, M, VT, N);
STOP_TIMING();
- if(INFO!=0){
- printf(" ERROR OCCURED INFO %d\n",INFO);
+ if( INFO != 0 ) {
+ printf(" ERROR OCCURED INFO %d\n",INFO);
}
/* DeAllocate Workspace */
MORSE_Dealloc_Workspace(&descT);
- if (jobu == MorseVec) {
- free( U );
+ if ( U != NULL ) {
+ free( U );
}
- if (jobvt == MorseVec) {
- free( VT );
+ if ( VT != NULL) {
+ free( VT );
}
PASTE_CODE_FREE_MATRIX( descA );
free( S );
diff --git a/timing/time_zlange_tile.c b/timing/time_zlange_tile.c
index 4ffe9e77a..d52d18986 100644
--- a/timing/time_zlange_tile.c
+++ b/timing/time_zlange_tile.c
@@ -77,7 +77,8 @@ RunTest(int *iparam, double *dparam, morse_time_t *t_)
free( A );
}
#endif
- PASTE_CODE_FREE_MATRIX( descA );
+ PASTE_CODE_FREE_MATRIX( descA );
+ (void)normmorse;
return 0;
}
diff --git a/timing/timing.c b/timing/timing.c
index 093ade83c..38c89fbfc 100644
--- a/timing/timing.c
+++ b/timing/timing.c
@@ -160,7 +160,6 @@ Test(int64_t n, int *iparam) {
fadds = (double)(_FADDS);
fmuls = (double)(_FMULS);
flops = 1e-9 * (fmuls * fp_per_mul + fadds * fp_per_add);
- gflops = 0.0;
if ( iparam[IPARAM_WARMUP] ) {
int status = RunTest( iparam, dparam, &(t[0]));
--
GitLab