From 09a6085cc71f7cfacfde259ed57009db800b7b63 Mon Sep 17 00:00:00 2001
From: Mathieu Faverge <mathieu.faverge@inria.fr>
Date: Tue, 30 Jan 2018 11:41:32 +0100
Subject: [PATCH] Silent warning about double identical test
---
coreblas/compute/core_zgeadd.c | 4 +---
coreblas/compute/core_zlatro.c | 2 +-
coreblas/compute/core_zpemv.c | 2 +-
coreblas/compute/core_ztradd.c | 4 +---
4 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/coreblas/compute/core_zgeadd.c b/coreblas/compute/core_zgeadd.c
index 259f4b61d..aa7c965ce 100644
--- a/coreblas/compute/core_zgeadd.c
+++ b/coreblas/compute/core_zgeadd.c
@@ -93,9 +93,7 @@ int CORE_zgeadd(MORSE_enum trans, int M, int N,
{
int i, j;
- if ((trans != MorseNoTrans) &&
- (trans != MorseTrans) &&
- (trans != MorseConjTrans))
+ if ((trans < MorseNoTrans) || (trans > MorseConjTrans))
{
coreblas_error(1, "illegal value of trans");
return -1;
diff --git a/coreblas/compute/core_zlatro.c b/coreblas/compute/core_zlatro.c
index 85c630ed1..ea97320c3 100644
--- a/coreblas/compute/core_zlatro.c
+++ b/coreblas/compute/core_zlatro.c
@@ -99,7 +99,7 @@ int CORE_zlatro(MORSE_enum uplo, MORSE_enum trans,
coreblas_error(1, "Illegal value of uplo");
return -1;
}
- if ((trans != MorseConjTrans) && (trans != MorseNoTrans) && (trans != MorseTrans) ) {
+ if ((trans < MorseNoTrans) || (trans > MorseConjTrans)) {
coreblas_error(2, "Illegal value of trans");
return -2;
}
diff --git a/coreblas/compute/core_zpemv.c b/coreblas/compute/core_zpemv.c
index 5cd8a128b..85ffd5a3b 100644
--- a/coreblas/compute/core_zpemv.c
+++ b/coreblas/compute/core_zpemv.c
@@ -146,7 +146,7 @@ int CORE_zpemv(MORSE_enum trans, int storev,
/* Check input arguments */
- if ((trans != MorseNoTrans) && (trans != MorseTrans) && (trans != MorseConjTrans)) {
+ if ((trans < MorseNoTrans) || (trans > MorseConjTrans)) {
coreblas_error(1, "Illegal value of trans");
return -1;
}
diff --git a/coreblas/compute/core_ztradd.c b/coreblas/compute/core_ztradd.c
index f14213b16..ab5b9ea59 100644
--- a/coreblas/compute/core_ztradd.c
+++ b/coreblas/compute/core_ztradd.c
@@ -118,9 +118,7 @@ int CORE_ztradd(MORSE_enum uplo, MORSE_enum trans, int M, int N,
return -1;
}
- if ((trans != MorseNoTrans) &&
- (trans != MorseTrans) &&
- (trans != MorseConjTrans))
+ if ((trans < MorseNoTrans) || (trans > MorseConjTrans))
{
coreblas_error(2, "illegal value of trans");
return -2;
--
GitLab