From cd3c2e9b5502ea4780c0964305284beafd4a33bf Mon Sep 17 00:00:00 2001 From: VIGNET Pierre <pierre.vignet@irisa.fr> Date: Thu, 19 Dec 2019 15:20:34 +0100 Subject: [PATCH] [lib] Tests: Add assertions on tests that test nothing --- .../clause_constraints/mcl/TestCLUnfolder.py | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/library/cadbiom/models/clause_constraints/mcl/TestCLUnfolder.py b/library/cadbiom/models/clause_constraints/mcl/TestCLUnfolder.py index 5c6e792..87727b5 100644 --- a/library/cadbiom/models/clause_constraints/mcl/TestCLUnfolder.py +++ b/library/cadbiom/models/clause_constraints/mcl/TestCLUnfolder.py @@ -305,27 +305,25 @@ class TestCLUnfolder(unittest.TestCase): model = model3() unfolder = create_unfolder(model) lfc = unfolder.free_clocks - res = len(lfc) == 0 - self.assert_(res,'Error in free clocks: model3') + self.assertEqual(len(lfc), 0, 'Error in free clocks: model3') lin = unfolder.inputs - res = len(lin) == 0 - self.assert_(res,'Error in inputs 1') + self.assertEqual(len(lin), 0,'Error in inputs 1') # model4: two free clocks and one input model = model4() unfolder = create_unfolder(model) lfc = unfolder.free_clocks - res = len(lfc) == 2 + self.assertEqual(len(lfc), 2, 'Error in free clocks: model4') found_names = {unfolder.get_var_name(clock) for clock in lfc} - res = found_names == {'hh2', 'hh1'} - self.assert_(res,'Error in free clocks: model4') + self.assertEqual( + found_names, + {'hh2', 'hh1'}, + 'Error in free clocks names: model4' + ) lin = unfolder.inputs - res = len(lin) == 1 + self.assertEqual(len(lin), 1, 'Error in inputs: model4') found_names = {unfolder.get_var_name(inpt) for inpt in lin} - res = found_names == {'in1'} - self.assert_(res,'Error in inputs: model4') - - + self.assertEqual(found_names, {'in1'}, 'Error in inputs names: model4') def init_forward_unfolding_part_1(unfolder): -- GitLab