MRF issueshttps://gitlab.inria.fr/pacanows/MRF/-/issues2020-11-08T18:45:32+01:00https://gitlab.inria.fr/pacanows/MRF/-/issues/23Check Scenes in assets/scenes work in spectral and rgb2020-11-08T18:45:32+01:00DUFAY ArthurCheck Scenes in assets/scenes work in spectral and rgbCornellbox OK (still some kinf of washed colors in spectral)
Ring OKCornellbox OK (still some kinf of washed colors in spectral)
Ring OKhttps://gitlab.inria.fr/pacanows/MRF/-/issues/85Cmake Refactor2022-10-06T14:46:10+02:00MURRAY DavidCmake RefactorNeed to wait for https://gitlab.inria.fr/pacanows/MRF/issues/2Need to wait for https://gitlab.inria.fr/pacanows/MRF/issues/2Malia 1.0.0 Beta 1MURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/64Code cleaning2020-12-04T00:24:12+01:00MURRAY DavidCode cleaningSome parts of the code have gradually become a mess (e.g. optix_renderer.hpp/cpp), making the code hard to understand and correctly document.Some parts of the code have gradually become a mess (e.g. optix_renderer.hpp/cpp), making the code hard to understand and correctly document.MURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/181Compilation fails with GCC 8.2.02020-12-15T10:00:49+01:00PACANOWSKI RomainCompilation fails with GCC 8.2.0> [ 13%] Building CXX object libmrf/core/CMakeFiles/mrf_core_rgb.dir/mrf/image/envi_spectral_image.cpp.o
> cd /home/pacanows/MRF3/build/libmrf/core && /usr/bin/c++ -DMRF_WITH_EIGEN_SUPPORT -I/home/pacanows/MRF3/libmrf/core -I/home/paca...> [ 13%] Building CXX object libmrf/core/CMakeFiles/mrf_core_rgb.dir/mrf/image/envi_spectral_image.cpp.o
> cd /home/pacanows/MRF3/build/libmrf/core && /usr/bin/c++ -DMRF_WITH_EIGEN_SUPPORT -I/home/pacanows/MRF3/libmrf/core -I/home/pacanows/MRF3/build/libmrf/core/mrf_rgb -I/projets/deeplayers/include/eigen3 -I/home/pacanows/MRF3/libmrf/externals/.. -O3 -DNDEBUG -Wall -Wextra -Wpedantic -fopenmp -std=gnu++1y -o CMakeFiles/mrf_core_rgb.dir/mrf/image/envi_spectral_image.cpp.o -c /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp: In lambda function:
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:502:76: erreur: no matching function for call to ‘regex_replace(std::string&, std::regex, const char [3])’
> param_value = std::regex_replace(param_value, std::regex("^ +"), "$1");
>
^
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:502:76: note: candidates are:
> In file included from /usr/include/c++/4.8.2/regex:62:0,
> from /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:12:
> /usr/include/c++/4.8.2/bits/regex.h:2162:5: note: template<class _Out_iter, class _Bi_iter, class _Rx_traits, class _Ch_type> _Out_iter std::regex_replace(_Out_iter, _Bi_iter, _Bi_iter, const std::basic_regex<_Ch_type, _Rx_traits>&, const std::basic_string<_Ch_type>&, std::regex_constants::match_flag_type)
> regex_replace(_Out_iter __out, _Bi_iter __first, _Bi_iter __last,
> ^
> /usr/include/c++/4.8.2/bits/regex.h:2162:5: note: template argument deduction/substitution failed:
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:502:76: note: deduced conflicting types for parameter ‘_Bi_iter’ (‘std::basic_regex<char>’ and ‘const char*’)
> param_value = std::regex_replace(param_value, std::regex("^ +"), "$1");
> ^
> In file included from /usr/include/c++/4.8.2/regex:62:0,
> from /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:12:
> /usr/include/c++/4.8.2/bits/regex.h:2182:5: note: template<class _Rx_traits, class _Ch_type> std::basic_string<_Ch_type> std::regex_replace(const std::basic_string<_Ch_type>&, const std::basic_regex<_Ch_type, _Rx_traits>&, const std::basic_string<_Ch_type>&, std::regex_constants::match_flag_type)
> regex_replace(const basic_string<_Ch_type>& __s,
> ^
> /usr/include/c++/4.8.2/bits/regex.h:2182:5: note: template argument deduction/substitution failed:
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:502:76: note: mismatched types ‘const std::basic_string<_Ch_type>’ and ‘const char [3]’
> param_value = std::regex_replace(param_value, std::regex("^ +"), "$1");
> ^
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp: In member function ‘mrf::image::IMAGE_LOAD_SAVE_FLAGS mrf::image::EnviSpectralImage::readHeader(std::istream&)’:
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:510:79: erreur: no matching function for call to ‘regex_replace(std::string&, std::regex, const char [3])’
> line = std::regex_replace(line, std::regex("^ +"), "$1");
>
^
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:510:79: note: candidates are:
> In file included from /usr/include/c++/4.8.2/regex:62:0,
> from /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:12:
> /usr/include/c++/4.8.2/bits/regex.h:2162:5: note: template<class _Out_iter, class _Bi_iter, class _Rx_traits, class _Ch_type> _Out_iter std::regex_replace(_Out_iter, _Bi_iter, _Bi_iter, const std::basic_regex<_Ch_type, _Rx_traits>&, const std::basic_string<_Ch_type>&, std::regex_constants::match_flag_type)
> regex_replace(_Out_iter __out, _Bi_iter __first, _Bi_iter __last,
> ^
> /usr/include/c++/4.8.2/bits/regex.h:2162:5: note: template argument deduction/substitution failed:
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:510:79: note: deduced conflicting types for parameter ‘_Bi_iter’ (‘std::basic_regex<char>’ and ‘const char*’)
> line = std::regex_replace(line, std::regex("^ +"), "$1");
> ^
> In file included from /usr/include/c++/4.8.2/regex:62:0,
> from /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:12:
> /usr/include/c++/4.8.2/bits/regex.h:2182:5: note: template<class _Rx_traits, class _Ch_type> std::basic_string<_Ch_type> std::regex_replace(const std::basic_string<_Ch_type>&, const std::basic_regex<_Ch_type, _Rx_traits>&, const std::basic_string<_Ch_type>&, std::regex_constants::match_flag_type)
> regex_replace(const basic_string<_Ch_type>& __s,
> ^
> /usr/include/c++/4.8.2/bits/regex.h:2182:5: note: template argument deduction/substitution failed:
> /home/pacanows/MRF3/libmrf/core/mrf/image/envi_spectral_image.cpp:510:79: note: mismatched types ‘const std::basic_string<_Ch_type>’ and ‘const char [3]’
> line = std::regex_replace(line, std::regex("^ +"), "$1");
> ^
> make[2]: *** [libmrf/core/CMakeFiles/mrf_core_rgb.dir/mrf/image/envi_spectral_image.cpp.o] Erreur 1
> make[2] : on quitte le répertoire « /home/pacanows/MRF3/build »
> make[1]: *** [libmrf/core/CMakeFiles/mrf_core_rgb.dir/all] Erreur 2
> make[1] : on quitte le répertoire « /home/pacanows/MRF3/build »
> make: *** [all] Erreur 2Alban FichetAlban Fichethttps://gitlab.inria.fr/pacanows/MRF/-/issues/119Compiling Malia with RENDERER_INTERACTIVE=OFF2020-12-04T15:59:05+01:00PACANOWSKI RomainCompiling Malia with RENDERER_INTERACTIVE=OFFMalia 1.0.0 Beta 1MURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/13Conversion des assets spectraux en RGB si malia_rgb est lancé2020-11-01T04:10:51+01:00PACANOWSKI RomainConversion des assets spectraux en RGB si malia_rgb est lancéMalia 1.0.0 Beta 1https://gitlab.inria.fr/pacanows/MRF/-/issues/12Conversions des assets spectraux -->RGB si malia ou malia_rgb est lancé2020-11-03T13:03:50+01:00PACANOWSKI RomainConversions des assets spectraux -->RGB si malia ou malia_rgb est lancéhttps://gitlab.inria.fr/pacanows/MRF/-/issues/126cornellbox_official is gray in RGB mode2020-05-05T15:14:25+02:00PACANOWSKI Romaincornellbox_official is gray in RGB modeMalia 1.0.0 Beta 1Alban FichetAlban Fichethttps://gitlab.inria.fr/pacanows/MRF/-/issues/28Correctly handling LD_LIBRARY_PATH and RPATH for LINUX2020-04-15T22:39:53+02:00PACANOWSKI RomainCorrectly handling LD_LIBRARY_PATH and RPATH for LINUXRight now the interactive version of malia renderer needs to locate the DLL (or shared library on Unices) of GLFW
at runtime.
Although `glfw.so` is installed in the same directory than malia (or pulse or pulsar or malia_rgb), executing
...Right now the interactive version of malia renderer needs to locate the DLL (or shared library on Unices) of GLFW
at runtime.
Although `glfw.so` is installed in the same directory than malia (or pulse or pulsar or malia_rgb), executing
malia from the command line in Linux requires either
- to be in $MRF_DIR/bin/ to launch the rendering engine
- to modify the LD_LIBRARY_PATH by adding $MRF_DIR/bin/
This is not satisfactory and we shall modify the CMakelists.txt according to this
to include more flexibility (cf. https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/RPATH-handling)PACANOWSKI RomainPACANOWSKI Romainhttps://gitlab.inria.fr/pacanows/MRF/-/issues/114Creating a SNAP file instead of an AppImage2022-10-06T14:46:15+02:00PACANOWSKI RomainCreating a SNAP file instead of an AppImagefor Malia?
for Spectral Viewer?for Malia?
for Spectral Viewer?Alban FichetAlban Fichethttps://gitlab.inria.fr/pacanows/MRF/-/issues/35Deep Testing of branch gpu spectral conversion2020-03-06T14:46:23+01:00PACANOWSKI RomainDeep Testing of branch gpu spectral conversionhttps://gitlab.inria.fr/pacanows/MRF/-/issues/63default -spp value should be lower2019-10-16T09:56:32+02:00PACANOWSKI Romaindefault -spp value should be lowerhttps://gitlab.inria.fr/pacanows/MRF/-/issues/179Dev build: kernels are not exported if modified2022-10-06T14:46:10+02:00MURRAY DavidDev build: kernels are not exported if modifiedWhen building target Malia/Malia_rgb, the kernels are exported only once in the build binary dir. Thus if the files in the MRF source dir are modified by the developper, they are not exported and used when running Malia.
I think we use ...When building target Malia/Malia_rgb, the kernels are exported only once in the build binary dir. Thus if the files in the MRF source dir are modified by the developper, they are not exported and used when running Malia.
I think we use something like this:
https://stackoverflow.com/questions/34799916/copy-file-from-source-directory-to-binary-directory-using-cmake
What do you think ?Alban FichetAlban Fichethttps://gitlab.inria.fr/pacanows/MRF/-/issues/22Directionnal lights in random light choose (material_eval.cu)2019-10-15T18:26:32+02:00DUFAY ArthurDirectionnal lights in random light choose (material_eval.cu)https://gitlab.inria.fr/pacanows/MRF/-/issues/31Display Image Size in UI in Camera settings TAB2019-10-03T17:31:58+02:00PACANOWSKI RomainDisplay Image Size in UI in Camera settings TABPACANOWSKI RomainPACANOWSKI Romainhttps://gitlab.inria.fr/pacanows/MRF/-/issues/37Display the SPP in the UI instead of the total number of samples for the whol...2019-10-10T18:38:49+02:00PACANOWSKI RomainDisplay the SPP in the UI instead of the total number of samples for the whole image?MURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/76Document arg parse2020-01-10T11:01:57+01:00MURRAY DavidDocument arg parseArg parse need more documentation about the use of "hasArgument" and "getSingle..."Arg parse need more documentation about the use of "hasArgument" and "getSingle..."MURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/191Drag & drop and dynamic loading not working2021-07-22T14:00:21+02:00MURRAY DavidDrag & drop and dynamic loading not workingMalia 1.0 patchMURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/49[EDIT]Interactive Renderer: Event not detected when focus is not on the rende...2019-10-10T18:37:12+02:00PACANOWSKI Romain[EDIT]Interactive Renderer: Event not detected when focus is not on the render areais it me or pushing the button "pause/resume rendering" does not work in Spectral mode ?is it me or pushing the button "pause/resume rendering" does not work in Spectral mode ?PACANOWSKI RomainPACANOWSKI Romainhttps://gitlab.inria.fr/pacanows/MRF/-/issues/81Envmap not removed when loading a scene without one2020-02-10T10:21:06+01:00MURRAY DavidEnvmap not removed when loading a scene without oneWhen using a scene with an envmap (e.g. table_lucy_envmap.msf), if another one without an envmap is loaded (e.g. material_export.msf"), the envmap is not removed.When using a scene with an envmap (e.g. table_lucy_envmap.msf), if another one without an envmap is loaded (e.g. material_export.msf"), the envmap is not removed.MURRAY DavidMURRAY David